You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* RunTests dotnet run --no-build
* Remove duplicate run
* Add to Build.props
* Treat CA2007 as a warning in RunTests
* NoWarn CA2007
* Ignore NU5104 for System.CommandLine prerelease package
* PR Feedback
* PR Feedback
* Generate .config/dotnet-tools.json
- add generation to GenerateFiles.csproj
- include all required versions in eng/Versions.props
- nit: bump tool versions slightly
- `dotnet-dump` move from `5.0.0-*` to `6.0.322601` is largest version bump
- have `git` ignore generated file
- nit: put `*.svclog` together w/ other extension exclusions
* Add tool packages to Helix correlation payloads
* Do not restore tools from network
- get tool packages from Helix correlation root
- to do this, save and restore NuGet.config file
- this removes `--version` from `dotnet-dump` and `dotnet-ef` installations
- will only have a single package for each tool in the correlation payload
* Do not pass `dotnet-ef` version to `RunTests`
- mostly cleanup; no longer needed
* Remove DotNetToolsInstaller.csproj
- mostly cleanup
- `dotnet-ef` tool now restored by Arcade's Tools.proj much earlier in our build because
most configured tool packages are needed in `RunTests` on Helix agents
* Add `--playwright` option in `Runtests`
- remove `INSTALLPLAYWRIGHT` define and `$env:INSTALLPLAYWRIGHT`
- always reference Microsoft.Playwright in `RunTests`
- nit: `InstallPlaywrightAsync()` wasn't `async`; fix it and rename to `InstallPlaywright()`
* Use Arcade SDK in `RunTests` and `Publish` project
- match most other projects in this repo
- remove empty Directory.Build.props and .targets files preventing Arcade imports
- exclude project build if `$(SkipTestBuild)` (though not a test project)
* Correct minor problems in `RunTests` source
* Use file-scoped namespaces in `RunTests` source
* Use VS code fixes in `RunTests`
* Use published `RunTests` output on Helix agents
* Move `RunTests` under eng/tools/
- don't need the project on Helix agents
- restore Directory.Build.* files removed when switching to Arcade
* Add `RunTests` to tools.slnf
* Rename `RunTests` project to `HelixTestRunner`
- less confusing given `RunTests` target and runtests.sh et cetera
* !fixup! Define `$(ArtifactsBinDir)` in helix.proj
* !fixup! Use `$(Configuration)` in helix.proj
* !fixup! Fix typo in property function
* !fixup! Fix `dotnet` syntax in runtests.sh
* !fixup! Correct `%(HelixCorrelationPayload.Destination)`
Co-authored-by: Doug Bunting <[email protected]>
Copy file name to clipboardExpand all lines: docs/UpdatingMajorVersionAndTFM.md
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -33,7 +33,7 @@ Once dotnet/runtime has updated their TFM, we update ours in the dependency upda
33
33
34
34
* In [eng/Versions.props](/eng/Versions.props), increment `DefaultNetCoreTargetFramework` by 1.
35
35
* Do a global repo search for the current version string, and update almost everything by 1 (e.g. find `net7`, replace with `net8`). See the PR linked above for examples - this shouldn't be done blindly, but on a case-by-case basis. Most things should be updated, and most choices should be obvious.
36
-
* Exceptions to this are [eng/tools/RepoTasks/RepoTasks.csproj](/eng/tools/RepoTasks/RepoTasks.csproj), [eng/tools/RepoTasks/RepoTasks.tasks](/eng/tools/RepoTasks/RepoTasks.tasks), and [eng/helix/content/RunTests/RunTests.csproj](/eng/helix/content/RunTests/RunTests.csproj). These build without the workarounds from [eng/tools/GenerateFiles/Directory.Build.targets.in](/eng/tools/GenerateFiles/Directory.Build.targets.in), and need to be kept at the previous TFM until we get an SDK containing a runtime with the new TFM. Generally this means we have to hard-code the previous TFM for these files, rather than using `DefaultNetCoreTargetFramework`.
36
+
* Exceptions to this are [eng/tools/RepoTasks/RepoTasks.csproj](/eng/tools/RepoTasks/RepoTasks.csproj), [eng/tools/RepoTasks/RepoTasks.tasks](/eng/tools/RepoTasks/RepoTasks.tasks), and [eng/tools/HelixTestRunner/HelixTestRunner.csproj](/eng/tools/HelixTestRunner/HelixTestRunner.csproj). These build without the workarounds from [eng/tools/GenerateFiles/Directory.Build.targets.in](/eng/tools/GenerateFiles/Directory.Build.targets.in), and need to be kept at the previous TFM until we get an SDK containing a runtime with the new TFM. Generally this means we have to hard-code the previous TFM for these files, rather than using `DefaultNetCoreTargetFramework`.
37
37
* Add a reference to the new `SiteExtensions` package for the previous Major Version.
38
38
1. Add references to [src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj](/src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj) to `Microsoft.AspNetCore.AzureAppServices.SiteExtension.{PreviousMajorVersion}.0.x64` and `Microsoft.AspNetCore.AzureAppServices.SiteExtension.{PreviousMajorVersion}.0.x86`.
39
39
2. Add entries in [eng/Versions.props](/eng/Versions.props) similar to [these](https://github.com/dotnet/aspnetcore/blob/216c92b78bce31d5e81a70b589707ec2ae5ab21a/eng/Versions.props#L224-L226) - the version should be from the latest released build of .Net.
@@ -56,4 +56,4 @@ Once dotnet/runtime has updated their TFM, we update ours in the dependency upda
56
56
57
57
## Ingesting an SDK with the new TFM
58
58
59
-
Typically we update the SDK we use in `main` every Monday. Once we have one that contains `Microsoft.Netcore.App` entries with the new TFM, we can update [eng/tools/RepoTasks/RepoTasks.csproj](/eng/tools/RepoTasks/RepoTasks.csproj), [eng/tools/RepoTasks/RepoTasks.tasks](/eng/tools/RepoTasks/RepoTasks.tasks), and [eng/helix/content/RunTests/RunTests.csproj](/eng/helix/content/RunTests/RunTests.csproj) to use `DefaultNetCoreTargetFramework` again rather than hard-coding the previous TFM.
59
+
Typically we update the SDK we use in `main` every Monday. Once we have one that contains `Microsoft.Netcore.App` entries with the new TFM, we can update [eng/tools/RepoTasks/RepoTasks.csproj](/eng/tools/RepoTasks/RepoTasks.csproj), [eng/tools/RepoTasks/RepoTasks.tasks](/eng/tools/RepoTasks/RepoTasks.tasks), and [eng/tools/HelixTestRunner/HelixTestRunner.csproj](/eng/helix/tools/HelixTestRunner.csproj) to use `DefaultNetCoreTargetFramework` again rather than hard-coding the previous TFM.
0 commit comments