SF-2996 Warn on unused private class members and fix current warnings (#3256)

Author: Nateowami

src/SIL.XForge.Scripture/ClientApp/src/app/checking/checking/checking.component.ts

@@ -155,7 +155,6 @@ export class CheckingComponent extends DataLoadingComponent implements OnInit, A
   };
   private questionsRemoteChangesSub?: Subscription;
   private text?: TextInfo;
-  private isProjectAdmin: boolean = false;
   private _scriptureAudioPlayer?: CheckingScriptureAudioPlayerComponent;
   private _showScriptureAudioPlayer: boolean = false;
 
@@ -562,10 +561,6 @@ export class CheckingComponent extends DataLoadingComponent implements OnInit, A
             this.projectDeleteSub = this.projectDoc.delete$
               .pipe(quietTakeUntilDestroyed(this.destroyRef))
               .subscribe(() => this.onRemovedFromProject());
-
-            this.projectService
-              .isProjectAdmin(routeProjectId, this.userService.currentUserId)
-              .then(isAdmin => (this.isProjectAdmin = isAdmin));
           }
 
           this.activeQuestionScope = routeScope;

src/SIL.XForge.Scripture/ClientApp/src/app/project/project.component.ts

@@ -6,7 +6,6 @@ import { SFProjectUserConfig } from 'realtime-server/lib/esm/scriptureforge/mode
 import { lastValueFrom, Observable } from 'rxjs';
 import { distinctUntilChanged, filter, first, map } from 'rxjs/operators';
 import { DataLoadingComponent } from 'xforge-common/data-loading-component';
-import { DialogService } from 'xforge-common/dialog.service';
 import { NoticeService } from 'xforge-common/notice.service';
 import { UserService } from 'xforge-common/user.service';
 import { quietTakeUntilDestroyed } from 'xforge-common/util/rxjs-util';
@@ -29,7 +28,6 @@ export class ProjectComponent extends DataLoadingComponent implements OnInit {
     private readonly userService: UserService,
     private readonly permissions: PermissionsService,
     private readonly resumeCheckingService: ResumeCheckingService,
-    private readonly dialogService: DialogService,
     noticeService: NoticeService,
     private destroyRef: DestroyRef
   ) {

src/SIL.XForge.Scripture/ClientApp/src/app/shared/text/text.component.spec.ts

@@ -1998,15 +1998,6 @@ class TestEnvironment {
     resolver(textDocBeingGotten);
     this.waitForEditor();
   }
-
-  /** Assert that in `parentNode`, there are only immediate children with name and order specified in
-   * `nodeOrderings`. */
-  private assertNodeOrder(parentNode: Node, nodeOrderings: string[]): void {
-    const childNodes: string[] = Array.from(parentNode.childNodes).map((n: ChildNode) => n.nodeName.toLowerCase());
-    expect(childNodes)
-      .withContext(`not expected list of nodes: [${childNodes}] does not match expected [${nodeOrderings}]`)
-      .toEqual(nodeOrderings);
-  }
 }
 
 function basicSimpleText(): { env: TestEnvironment; segmentRange: QuillRange } {

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation.component.spec.ts

@@ -255,7 +255,7 @@ describe('DraftGenerationComponent', () => {
     });
 
     it('does not subscribe to build when project does not have drafting enabled', () => {
-      const _ = new TestEnvironment(() => TestEnvironment.initProject('user01', false));
+      new TestEnvironment(() => TestEnvironment.initProject('user01', false));
       expect(mockDraftGenerationService.getLastCompletedBuild).not.toHaveBeenCalled();
       expect(mockDraftGenerationService.getBuildProgress).not.toHaveBeenCalled();
     });

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/lynx/insights/lynx-insights-panel/lynx-insights-panel-header/lynx-insights-panel-header.component.ts

@@ -9,7 +9,6 @@ import {
   LynxInsightType,
   LynxInsightTypes
 } from 'realtime-server/lib/esm/scriptureforge/models/lynx-insight';
-import { I18nService } from 'xforge-common/i18n.service';
 import { quietTakeUntilDestroyed } from 'xforge-common/util/rxjs-util';
 import { LynxInsightStateService } from '../../lynx-insight-state.service';
 
@@ -32,7 +31,6 @@ export class LynxInsightsPanelHeaderComponent implements OnInit {
 
   constructor(
     private readonly destroyRef: DestroyRef,
-    private readonly i18n: I18nService,
     readonly state: LynxInsightStateService
   ) {}
 

src/SIL.XForge.Scripture/ClientApp/src/xforge-common/feature-flags/feature-flag.service.ts

@@ -221,21 +221,21 @@ export class FeatureFlagService {
     this.featureFlagStore
   );
 
-  private readonly showNmtDrafting: FeatureFlag = new ServerOnlyFeatureFlag(
+  readonly showNmtDrafting: FeatureFlag = new ServerOnlyFeatureFlag(
     'SHOW_NMT_DRAFTING',
     'Show NMT drafting',
     2,
     this.featureFlagStore
   );
 
-  private readonly allowForwardTranslationNmtDrafting: FeatureFlag = new ServerOnlyFeatureFlag(
+  readonly allowForwardTranslationNmtDrafting: FeatureFlag = new ServerOnlyFeatureFlag(
     'ALLOW_FORWARD_TRANSLATION_NMT_DRAFTING',
     'Allow Forward Translation NMT drafting',
     3,
     this.featureFlagStore
   );
 
-  private readonly scriptureAudio: FeatureFlag = new ServerOnlyFeatureFlag(
+  readonly scriptureAudio: FeatureFlag = new ServerOnlyFeatureFlag(
     'SCRIPTURE_AUDIO',
     'Scripture audio',
     4,
@@ -263,49 +263,49 @@ export class FeatureFlagService {
     this.featureFlagStore
   );
 
-  private readonly machineInProcess: FeatureFlag = new ServerOnlyFeatureFlag(
+  readonly machineInProcess: FeatureFlag = new ServerOnlyFeatureFlag(
     'MachineInProcess',
     'Use In-Process Machine for Suggestions',
     8,
     this.featureFlagStore
   );
 
-  private readonly serval: FeatureFlag = new ServerOnlyFeatureFlag(
+  readonly serval: FeatureFlag = new ServerOnlyFeatureFlag(
     'Serval',
     'Use Serval for Suggestions',
     9,
     this.featureFlagStore
   );
 
-  private readonly useEchoForPreTranslation: FeatureFlag = new ServerOnlyFeatureFlag(
+  readonly useEchoForPreTranslation: FeatureFlag = new ServerOnlyFeatureFlag(
     'UseEchoForPreTranslation',
     'Allow Echo for Pre-Translation Drafting',
     10,
     this.featureFlagStore
   );
 
-  private readonly allowFastTraining: FeatureFlag = new ServerOnlyFeatureFlag(
+  readonly allowFastTraining: FeatureFlag = new ServerOnlyFeatureFlag(
     'ALLOW_FAST_TRAINING',
     'Allow Fast Pre-Translation Training',
     11,
     this.featureFlagStore
   );
 
-  private readonly uploadParatextZipForPreTranslation: FeatureFlag = new ServerOnlyFeatureFlag(
+  readonly uploadParatextZipForPreTranslation: FeatureFlag = new ServerOnlyFeatureFlag(
     'UploadParatextZipForPreTranslation',
     'Upload Paratext Zip Files for Pre-Translation Drafting',
     12,
     this.featureFlagStore
   );
 
-  private readonly allowAdditionalTrainingSource: FeatureFlag = new ServerOnlyFeatureFlag(
+  readonly allowAdditionalTrainingSource: FeatureFlag = new ServerOnlyFeatureFlag(
     'AllowAdditionalTrainingSource',
     'Allow mixing in an additional training source',
     13,
     this.featureFlagStore
   );
 
-  private readonly updatedLearningRateForServal: FeatureFlag = new ServerOnlyFeatureFlag(
+  readonly updatedLearningRateForServal: FeatureFlag = new ServerOnlyFeatureFlag(
     'UpdatedLearningRateForServal',
     'Updated Learning Rate For Serval',
     14,

src/SIL.XForge.Scripture/ClientApp/src/xforge-common/memory-realtime-remote-store.ts

@@ -11,11 +11,10 @@ import { RealtimeDocAdapter, RealtimeQueryAdapter, RealtimeRemoteStore } from '.
  * This is the memory-based implementation of the real-time remote store. It is useful for testing.
  */
 export class MemoryRealtimeRemoteStore extends RealtimeRemoteStore {
-  private getAccessToken?: () => Promise<string | undefined>;
   private readonly snapshots = new Map<string, Map<string, Snapshot>>();
 
-  async init(getAccessToken: () => Promise<string | undefined>): Promise<void> {
-    this.getAccessToken = getAccessToken;
+  async init(_getAccessToken: () => Promise<string | undefined>): Promise<void> {
+    // getAccessToken is not used in this memory implementation
   }
 
   addSnapshot<T>(collection: string, snapshot: Snapshot<T>): void {

src/SIL.XForge.Scripture/ClientApp/tsconfig.json

@@ -25,7 +25,8 @@
     "paths": {
       "xforge-common/*": ["./src/xforge-common/*"]
     },
-    "useDefineForClassFields": false
+    "useDefineForClassFields": false,
+    "noUnusedLocals": true
   },
   "angularCompilerOptions": {
     "enableI18nLegacyMessageIdFormat": false,