Upgrade dependencies and meta tweaks

Author: sindresorhus

.editorconfig

@@ -7,6 +7,6 @@ charset = utf-8
 trim_trailing_whitespace = true
 insert_final_newline = true
 
-[{package.json,*.yml}]
+[*.yml]
 indent_style = space
 indent_size = 2

.gitignore

@@ -1,2 +1,3 @@
 node_modules
+yarn.lock
 extension/dist

.npmrc

@@ -0,0 +1 @@
+package-lock=false

.travis.yml

@@ -1,4 +1,3 @@
-sudo: false
 language: node_js
 node_js:
   - 'node'

extension/icon-38.png

@@ -2,9 +2,9 @@
 	"name": "Notifier for GitHub",
 	"version": "3.0.5",
 	"description": "Displays your GitHub notifications unread count",
-	"homepage_url": "https://github.com/sindresorhus/notifier-for-github-chrome",
+	"homepage_url": "https://github.com/sindresorhus/notifier-for-github",
 	"manifest_version": 2,
-	"minimum_chrome_version": "52",
+	"minimum_chrome_version": "65",
 	"icons": {
 		"128": "icon-128.png"
 	},

extension/icon-notif-128.png

@@ -9,9 +9,12 @@ const render = (text, color, title) => {
 const getCountString = count => {
 	if (count === 0) {
 		return '';
-	} else if (count > 9999) {
+	}
+
+	if (count > 9999) {
 		return '∞';
 	}
+
 	return String(count);
 };
 

extension/manifest.json

@@ -37,9 +37,12 @@ const TabsService = {
 		}).then(tabs => {
 			if (tabs && tabs.length > 0) {
 				return this.updateTab(tabs[0].id, {url, active: true});
-			} else if (tab && tab.url === 'chrome://newtab/') {
+			}
+
+			if (tab && tab.url === 'chrome://newtab/') {
 				return this.updateTab(null, {url, active: false});
 			}
+
 			return this.createTab(url);
 		});
 	}

extension/src/badge.js

@@ -1,21 +1,9 @@
-The MIT License (MIT)
+MIT License
 
 Copyright (c) Sindre Sorhus <[email protected]> (sindresorhus.com)
 
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
+Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
 
-The above copyright notice and this permission notice shall be included in
-all copies or substantial portions of the Software.
+The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
 
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-THE SOFTWARE.
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

extension/src/tabs-service.js

@@ -1,22 +1,20 @@
 {
-	"license": "MIT",
-	"repository": "sindresorhus/notifier-for-github",
 	"scripts": {
 		"release": "npm run build && webstore upload --source=extension --auto-publish",
 		"test": "xo && ava",
-		"build": "webpack --config"
+		"build": "webpack --mode=development"
 	},
 	"devDependencies": {
-		"ava": "^0.19.0",
+		"ava": "^0.25.0",
 		"chrome-stub": "^1.3.2",
 		"chrome-webstore-upload-cli": "^1.0.3",
 		"istanbul": "^0.4.0",
 		"moment": "^2.14.1",
 		"p-immediate": "^2.1.0",
-		"sinon": "^1.15.4",
-		"url-search-params": "^0.6.1",
-		"webpack": "^1.13.2",
-		"xo": "^0.18.0"
+		"sinon": "^4.5.0",
+		"webpack": "^4.6.0",
+		"webpack-cli": "^2.0.15",
+		"xo": "^0.20.3"
 	},
 	"ava": {
 		"files": "test/*-test.*"

license

@@ -13,8 +13,8 @@ It checks for new GitHub notifications every minute.
 
 *Make sure to add a token in the options.*
 
-![](screenshot.png)
-![](screenshot-webstore2.png)
+![](media/screenshot.png)
+![](media/screenshot-webstore2.png)
 
 
 ## Install
@@ -43,7 +43,7 @@ If you want to receive (useful) desktop notifications for any private repositori
 
 ## Desktop notifications
 
-![](screenshot-notification.png)
+![](media/screenshot-notification.png)
 
 You can opt-in to receive desktop notifications for new notifications on GitHub. The extension checks for new notifications every minute, and displays notifications that arrived after the last check if there are any. Clicking on the notification opens it on GitHub.
 

icon.ai media/icon.ai

@@ -1,5 +1,6 @@
+'use strict';
+const {URLSearchParams} = require('url');
 const chromeStub = require('chrome-stub');
-const URLSearchParams = require('url-search-params');
 
 module.exports = {
 	setupWindow: () => {

media/promo.png

@@ -1,11 +1,13 @@
+'use strict';
+const path = require('path');
+
 module.exports = {
 	entry: {
 		main: './extension/main.js',
 		options: './extension/options.js'
 	},
 	output: {
-		path: './extension/dist',
-		filename: '[name].js',
-		publicPath: ''
+		path: path.join(__dirname, 'extension/dist'),
+		filename: '[name].js'
 	}
 };