-
Notifications
You must be signed in to change notification settings - Fork 75
Use of tracing
in Drop
will cause SIGABRT in thread-local context
#231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the report! Perhaps just removing the use of tracing in the following two places would suffice? Line 259 in dd7b207
Line 281 in dd7b207
I think it's also reasonable to make tracing optional like done in another smol-rs crate: smol-rs/blocking#60 |
They are now disabled by default and can be enabled using the feature flag `tracing_in_drop` if necessary. Closes #231.
Please test if PR #238 fixes this. |
Would it be possible to have a proper test for this? |
(Related: rust-lang/rust#29488.) |
I'm writting an egui app. And from some point of time my app stop terminating gracefully. And I git few panics instead.
A quick investigation led me to the idea that the order of Drop is not controlled in any way, and thread-local tracing was dropped first, so by the time the tracing method was called with nothing.
The text was updated successfully, but these errors were encountered: