fix: handle out of sync in resolutions for yarn 2

Author: gemaxim

lib/dep-graph-builders/yarn-lock-v2/utils.ts

@@ -118,6 +118,24 @@ export const getYarnLockV2ChildNode = (
 
   if (resolvedVersionFromResolution) {
     const childNodeKeyFromResolution = `${name}@${resolvedVersionFromResolution}`;
+    if (!pkgs[childNodeKeyFromResolution]) {
+      if (strictOutOfSync && !/^file:/.test(resolvedVersionFromResolution)) {
+        throw new OutOfSyncError(
+          childNodeKeyFromResolution,
+          LockfileType.yarn2,
+        );
+      } else {
+        return {
+          id: childNodeKeyFromResolution,
+          name: name,
+          version: resolvedVersionFromResolution,
+          dependencies: {},
+          isDev: depInfo.isDev,
+          missingLockFileEntry: true,
+        };
+      }
+    }
+
     const {
       version: versionFromResolution,
       dependencies,

test/jest/dep-graph-builders/fixtures/yarn-lock-v2/real/out-of-sync-resolutions/expected.json

@@ -0,0 +1,67 @@
+{
+    "schemaVersion": "1.3.0",
+    "pkgManager": {
+      "name": "yarn"
+    },
+    "pkgs": [
+      {
+        "id": "[email protected]",
+        "info": {
+          "name": "resolutions-out-of-sync",
+          "version": "0.0.1"
+        }
+      },
+      {
+        "id": "[email protected]",
+        "info": {
+          "name": "debug",
+          "version": "4.3.1"
+        }
+      },
+      {
+        "id": "[email protected]",
+        "info": {
+          "name": "ms",
+          "version": "1.0.0"
+        }
+      }
+    ],
+    "graph": {
+      "rootNodeId": "root-node",
+      "nodes": [
+        {
+          "nodeId": "root-node",
+          "pkgId": "[email protected]",
+          "deps": [
+            {
+              "nodeId": "[email protected]"
+            }
+          ]
+        },
+        {
+          "nodeId": "[email protected]",
+          "pkgId": "[email protected]",
+          "deps": [
+            {
+              "nodeId": "[email protected]"
+            }
+          ],
+          "info": {
+            "labels": {
+              "scope": "prod"
+            }
+          }
+        },
+        {
+          "nodeId": "[email protected]",
+          "pkgId": "[email protected]",
+          "deps": [],
+          "info": {
+            "labels": {
+              "scope": "prod"
+            }
+          }
+        }
+      ]
+    }
+  }

test/jest/dep-graph-builders/fixtures/yarn-lock-v2/real/out-of-sync-resolutions/package.json

@@ -0,0 +1,10 @@
+{
+  "name": "resolutions-out-of-sync",
+  "version": "0.0.1",
+  "dependencies": {
+    "debug": "4.3.1"
+  },
+  "resolutions": {
+    "ms": "1.0.0"
+  }
+}

test/jest/dep-graph-builders/fixtures/yarn-lock-v2/real/out-of-sync-resolutions/yarn.lock

@@ -0,0 +1,26 @@
+# This file is generated by running "yarn install" inside your project.
+# Manual changes might be lost - proceed with caution!
+
+__metadata:
+  version: 4
+  cacheKey: 7
+
+"debug@npm:4.3.1":
+  version: 4.3.1
+  resolution: "debug@npm:4.3.1"
+  dependencies:
+    ms: 2.1.2
+  peerDependenciesMeta:
+    supports-color:
+      optional: true
+  checksum: 0d41ba5177510e8b388dfd7df143ab0f9312e4abdaba312595461511dac88e9ef8101939d33b4e6d37e10341af6a5301082e4d7d6f3deb4d57bc05fc7d296fad
+  languageName: node
+  linkType: hard
+
+"resolutions-simple@workspace:.":
+  version: 0.0.0-use.local
+  resolution: "resolutions-simple@workspace:."
+  dependencies:
+    debug: 4.3.1
+  languageName: unknown
+  linkType: soft

test/jest/dep-graph-builders/yarn-lock-v2.test.ts

@@ -3,13 +3,15 @@ import { readFileSync } from 'fs';
 import { join } from 'path';
 import { YarnLockV2ProjectParseOptions } from '../../../lib/dep-graph-builders/types';
 import { parseYarnLockV2Project } from '../../../lib/dep-graph-builders/yarn-lock-v2/simple';
+import { LockfileType, OutOfSyncError } from '../../../lib';
 
 describe('yarn.lock v2 "real" projects', () => {
   describe.each([
     'git-remote-url',
     'goof',
     'resolutions-simple',
     'resolutions-scoped',
+    'out-of-sync-resolutions',
   ])('[simple tests] project: %s ', (fixtureName) => {
     test('matches expected - no pruning', async () => {
       const pkgJsonContent = readFileSync(
@@ -56,6 +58,31 @@ describe('yarn.lock v2 "real" projects', () => {
     });
   });
 
+  test('project: out-of-sync-resolutions -> throws OutOfSyncError', async () => {
+    const fixtureName = 'out-of-sync-resolutions';
+    const pkgJsonContent = readFileSync(
+      join(
+        __dirname,
+        `./fixtures/yarn-lock-v2/real/${fixtureName}/package.json`,
+      ),
+      'utf8',
+    );
+    const yarnLockContent = readFileSync(
+      join(__dirname, `./fixtures/yarn-lock-v2/real/${fixtureName}/yarn.lock`),
+      'utf8',
+    );
+    const opts: YarnLockV2ProjectParseOptions = {
+      includeDevDeps: false,
+      includeOptionalDeps: true,
+      strictOutOfSync: true,
+      pruneWithinTopLevelDeps: false,
+    };
+
+    await expect(
+      parseYarnLockV2Project(pkgJsonContent, yarnLockContent, opts),
+    ).rejects.toThrow(new OutOfSyncError('[email protected]', LockfileType.yarn2));
+  });
+
   it('Workspace with resolutions', async () => {
     const rootPkgJsonContent = readFileSync(
       join(