Skip to content

Commit 466597b

Browse files
test: adapter.close() is now called by io.close()
Related: socketio/socket.io@bf64870
1 parent 9e9fc60 commit 466597b

File tree

4 files changed

+12
-24
lines changed

4 files changed

+12
-24
lines changed

package-lock.json

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/broadcast.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,7 @@ describe("broadcast()", function () {
3535
});
3636

3737
it("broadcasts to all clients in a namespace", (done) => {
38-
const partialDone = times(3, () => {
39-
servers.forEach((server) => server.of("/custom").adapter.close());
40-
done();
41-
});
38+
const partialDone = times(3, done);
4239

4340
servers.forEach((server) => server.of("/custom"));
4441

test/connection-state-recovery.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ describe("connection state recovery", () => {
2121
});
2222

2323
afterEach(() => {
24-
servers[0].of("/foo").adapter.close();
2524
cleanup();
2625
});
2726

test/util.ts

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -149,17 +149,9 @@ export function setup({
149149
clientSockets,
150150
ports,
151151
cleanup: () => {
152-
servers.forEach((server) => {
153-
// @ts-ignore
154-
server.httpServer.close();
155-
server.of("/").adapter.close();
156-
});
157-
clientSockets.forEach((socket) => {
158-
socket.disconnect();
159-
});
160-
redisClients.forEach((redisClient) => {
161-
redisClient.quit();
162-
});
152+
servers.forEach((server) => server.close());
153+
clientSockets.forEach((socket) => socket.disconnect());
154+
redisClients.forEach((redisClient) => redisClient.quit());
163155
},
164156
});
165157
}

0 commit comments

Comments
 (0)