Skip to content

Move towards React host refs instead of findNodeHandle for compatibility react-native-web@next #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jfrolich opened this issue Apr 16, 2020 · 2 comments

Comments

@jfrolich
Copy link

findNodeHandle should not be used anymore and recently it breaks compatibility with new builds of react-native-web. I also think this will enable react-native-reanimated to be compatible with function components, so that would be nice!

See here for more info: necolas/react-native-web#1219 (comment)

Related: software-mansion/react-native-reanimated#738

@jfrolich
Copy link
Author

jfrolich commented Aug 3, 2020

It seems not to be fixed yet. In the mean time react-native-web has reached a new stable version.

@WoLewicki
Copy link
Member

Looking at the code here:

if (Platform.OS === 'web') return node;
it seems like it is now handled on web. I will close this issue then. Feel free to comment if something is wrong and we can always reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants