Chrome plugin not working for certain typescript atoms #509
Comments
|
I've also noticed
|
dadlerj
added
browser-extension
team/graph
|
Hey, thanks for reporting! Looks like this is a javascript-typescript-langserver issue. @felixfbecker would know for sure. I'll leave this issue open before moving it to that issue tracker so Felix can confirm. And the "Limited Functionality" message is a misleading prompt and will be removed soon. It's just trying to tell you that you can't get all the features from sourcegraph.com that you can with your own instance of Sourcegraph (e.g. private repo support). And FYI, the browser extension is also open source so feel free to file issues you're having with it in it's issue tracker! |
|
The official TypeScript service (that we use) doesn't show a hover for the visibility modifiers, only for the actual symbol name. I think that is as designed. You're seeing the errors cause there was an install error and when no hover is returned it may be caused by this error so we show it, but we still try to get the hover and return it if we find it (which is what happens when you hover the symbol name) |
|
@epelc The |
|
@felixfbecker Is there any resolution/change, or is this wontfix? |
|
I think there is nothing actionable here |
This implements https://github.com/sourcegraph/sourcegraph/issues/18330 by querying the locations of `.batchignore` files in each repository yielded by the `on` attribute in a batch spec. If locations were found, the repository is ignored. This can be overwritten by using the `-force-override-ignore` flag. Example: given my instance has the following repositories: - `github.com/sourcegraph-testing/zap` - `github.com/sourcegraph-testing/titan` - `github.com/sourcegraph-testing/tidb` - `github.com/sourcegraph-testing/etcd` - `github.com/sourcegraph-testing/batch-changes-testing-ignore` And I use the following batch spec: ```yaml on: - repositoriesMatchingQuery: repohasfile:README.md repo:sourcegraph-testing steps: - run: echo "a horse says 'hello'" >> README.md container: alpine:3 ``` with this change the `batch-changes-testing-ignore` repository will be ignored: - no archive will be downloaded - no steps executed A message is printed that says it's ignored.
Steps to reproduce:
protectedon this linehttps://github.com/angular/flex-layout/blob/master/src/lib/flex/layout/layout.ts#L46
Hovering over the field name works though.
Expected behavior:
Should show type info
Actual behavior:
You get an error. I've also seen errors like
Error fetching hover from language server:. Not sure if this is intermittent issues on entire projects or just some local typescript problem? I've been seeing errors for a couple weeks like this. Today is the first time I noticed it halfway working on some things as pointed out by Dan.The text was updated successfully, but these errors were encountered: