From 8664e3ddee3d811bfd83a1596c3042025f14c079 Mon Sep 17 00:00:00 2001 From: Farhan Attamimi Date: Wed, 31 Oct 2018 12:01:26 -0700 Subject: [PATCH 1/3] fix: code intel on diffs with newly added files --- packages/browser-extensions/src/libs/github/dom_functions.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/browser-extensions/src/libs/github/dom_functions.ts b/packages/browser-extensions/src/libs/github/dom_functions.ts index 41ea52c03ba3..8e2dbf58552e 100644 --- a/packages/browser-extensions/src/libs/github/dom_functions.ts +++ b/packages/browser-extensions/src/libs/github/dom_functions.ts @@ -202,8 +202,10 @@ export const getDiffLineRanges: CodeView['getLineRanges'] = (codeView, part) => if (isCode) { const line = row.querySelector( `td${isDomSplitDiff() ? `:nth-of-type(${part === 'base' ? 2 : 4})` : '.blob-code'}` - )! + ) + if ( + !line || line.classList.contains('empty-cell') || line.classList.contains(part === 'base' ? 'blob-code-addition' : 'blob-code-deletion') ) { From 9b7a7426183259711b6e598ccffa323538b29375 Mon Sep 17 00:00:00 2001 From: Farhan Attamimi Date: Thu, 1 Nov 2018 11:28:01 -0700 Subject: [PATCH 2/3] fix: add check for data-line-number to isCode --- packages/browser-extensions/src/libs/github/dom_functions.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/browser-extensions/src/libs/github/dom_functions.ts b/packages/browser-extensions/src/libs/github/dom_functions.ts index 8e2dbf58552e..e29e27ddad00 100644 --- a/packages/browser-extensions/src/libs/github/dom_functions.ts +++ b/packages/browser-extensions/src/libs/github/dom_functions.ts @@ -197,7 +197,7 @@ export const getDiffLineRanges: CodeView['getLineRanges'] = (codeView, part) => for (const row of codeView.querySelectorAll('tr')) { const isCode = - !row.classList.contains('js-expandable-line') && !row.classList.contains('js-inline-comments-container') + !row.classList.contains('js-expandable-line') && !row.classList.contains('js-inline-comments-container') && !row.querySelector('[data-line-number="..."]') if (isCode) { const line = row.querySelector( From 4314ff542cd6ba2f4a11c73cdcbccfffa1cfa200 Mon Sep 17 00:00:00 2001 From: Farhan Attamimi Date: Thu, 1 Nov 2018 11:55:35 -0700 Subject: [PATCH 3/3] chore: prettier --- packages/browser-extensions/src/libs/github/dom_functions.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/browser-extensions/src/libs/github/dom_functions.ts b/packages/browser-extensions/src/libs/github/dom_functions.ts index e29e27ddad00..75212c717b17 100644 --- a/packages/browser-extensions/src/libs/github/dom_functions.ts +++ b/packages/browser-extensions/src/libs/github/dom_functions.ts @@ -197,7 +197,9 @@ export const getDiffLineRanges: CodeView['getLineRanges'] = (codeView, part) => for (const row of codeView.querySelectorAll('tr')) { const isCode = - !row.classList.contains('js-expandable-line') && !row.classList.contains('js-inline-comments-container') && !row.querySelector('[data-line-number="..."]') + !row.classList.contains('js-expandable-line') && + !row.classList.contains('js-inline-comments-container') && + !row.querySelector('[data-line-number="..."]') if (isCode) { const line = row.querySelector(