Skip to content

Commit f2eefbd

Browse files
authored
Improve section "Close the tip"
Improve code examples to give context about where the code to close the tip have to be added in UIKit.
1 parent 04e17b9 commit f2eefbd

File tree

1 file changed

+15
-6
lines changed

1 file changed

+15
-6
lines changed

en/tutorials/tipkit.md

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -261,19 +261,28 @@ In the method, provide a reason why you closed the tip:
261261
- `.displayCountExceeded` - the tip has been shown the maximum number of times
262262
- `.tipClosed` - the user has clearly closed the tip
263263

264-
In UIKit, you need to add code for the cross. For `popover`-tip, close the controller:
264+
In UIKit, you need to add code for the cross.
265+
For `popover`-tip, close the controller:
265266

266267
```swift
267-
if presentedViewController is TipUIPopoverViewController {
268-
dismiss(animated: true)
268+
if shouldDisplay {
269+
...
270+
} else {
271+
if presentedViewController is TipUIPopoverViewController {
272+
dismiss(animated: true)
273+
}
269274
}
270275
```
271276

272277
For the `inline`-tip, we remove the view:
273278

274279
```swift
275-
if let tipView = view.subviews.first(where: { $0 is TipUIView }) {
276-
tipView.removeFromSuperview()
280+
if shouldDisplay {
281+
...
282+
} else {
283+
if let tipView = view.subviews.first(where: { $0 is TipUIView }) {
284+
tipView.removeFromSuperview()
285+
}
277286
}
278287
```
279288

@@ -490,4 +499,4 @@ Add to AppDelegate:
490499
try? Tips.resetDatastore()
491500
```
492501

493-
> Remember to remove `.resetDatastore`, otherwise the tips will be shown all the time in the release.
502+
> Remember to remove `.resetDatastore`, otherwise the tips will be shown all the time in the release.

0 commit comments

Comments
 (0)