Skip to content
This repository was archived by the owner on Jan 18, 2022. It is now read-only.

Commit ddc6a1a

Browse files
authored
CommandDiffStorageBase rename (#1345)
1 parent 7f83f4f commit ddc6a1a

File tree

5 files changed

+4
-3
lines changed

5 files changed

+4
-3
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
- Added component result type filters to playground QBI queries. [#1338](https://github.com/spatialos/gdk-for-unity/pull/1338)
2626
- Replaced `InitUISystem` with the `InitUIBehaviour` script on the `Character` prefab. [#1338](https://github.com/spatialos/gdk-for-unity/pull/1338)
2727
- Removed `ViewCommandBuffer` as it is no longer required. [#1344](https://github.com/spatialos/gdk-for-unity/pull/1344)
28+
- Renamed faulty named `DiffSpawnCubeCommandStorage` to `CommandDiffStorageBase`. [#1345](https://github.com/spatialos/gdk-for-unity/pull/1345)
2829

2930
## `0.3.4` - 2020-03-16
3031

test-project/Assets/Generated/Source/improbable/dependentschema/DependentDataComponentCommandDiffStorage.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ namespace Improbable.DependentSchema
1010
public partial class DependentDataComponent
1111
{
1212
private class DiffBarCommandCommandStorage
13-
: DiffSpawnCubeCommandStorage<BarCommand.ReceivedRequest, BarCommand.ReceivedResponse>
13+
: CommandDiffStorageBase<BarCommand.ReceivedRequest, BarCommand.ReceivedResponse>
1414
{
1515
public override uint ComponentId => Improbable.DependentSchema.DependentDataComponent.ComponentId;
1616
public override uint CommandId => 1;

workers/unity/Packages/io.improbable.gdk.core/.codegen/Source/Generators/Core/CommandDiffStorageGenerator.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ private static Text GenerateCommandStorage(UnityCommandDetails command, string q
4040

4141
return Text.New($@"
4242
private class Diff{command.PascalCaseName}CommandStorage
43-
: DiffSpawnCubeCommandStorage<{receivedRequestType}, {receivedResponseType}>
43+
: CommandDiffStorageBase<{receivedRequestType}, {receivedResponseType}>
4444
{{
4545
public override uint ComponentId => {qualifiedNamespace}.{componentName}.ComponentId;
4646
public override uint CommandId => {command.CommandIndex};

workers/unity/Packages/io.improbable.gdk.core/Commands/CommandStorageBase.cs renamed to workers/unity/Packages/io.improbable.gdk.core/Commands/CommandDiffStorageBase.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
namespace Improbable.Gdk.Core.Commands
55
{
6-
public abstract class DiffSpawnCubeCommandStorage<TRequest, TResponse> : IComponentCommandDiffStorage
6+
public abstract class CommandDiffStorageBase<TRequest, TResponse> : IComponentCommandDiffStorage
77
, IDiffCommandRequestStorage<TRequest>
88
, IDiffCommandResponseStorage<TResponse>
99
where TRequest : struct, IReceivedCommandRequest

0 commit comments

Comments
 (0)