Skip to content

Default version of Awailitility is not compatible with Kotlin 1.9 baseline #45673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
agebhar1 opened this issue May 26, 2025 · 1 comment
Closed

Default version of Awailitility is not compatible with Kotlin 1.9 baseline #45673

agebhar1 opened this issue May 26, 2025 · 1 comment
Assignees
@snicoll
Labels
status: noteworthy A noteworthy issue to call out in the release notes type: bug A general bug
Milestone
3.5.1

Comments

@agebhar1
Copy link
Contributor

In #44602 awaitility was upgraded from 4.2.2 to 4.3.0. From the changeset of 4.3.0 awaitility/awaitility@awaitility-4.2.2...awaitility-4.3.0 the required Kotlin version was upgraded to 2 awaitility/awaitility@2a9814b.

Spring Boot 3.5 depends on Kotlin 1.9.x which breaks compilation of existing projects.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 26, 2025
@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label May 26, 2025
@philwebb
Copy link
Member

I'd probably vote for a downgrade in this instance. Looking at the awaitility changelog it seems like the new untilAsserted supplier and a consumer methods are the main new feature for Java users. I think I'd rather keep Kotlin compatibility and make Java users override the version if they want the new feature.

We can upgrade in 4.0.0 since we'll be on a Kotlin 2 baseline.

@wilkinsona wilkinsona changed the title awailitility 4.3 is not compatible with Kotlin 1.9 Awailitility 4.3 is not compatible with Kotlin 1.9 May 28, 2025
@wilkinsona wilkinsona changed the title Awailitility 4.3 is not compatible with Kotlin 1.9 Default version of Awailitility is not compatible with Kotlin 1.9 baseline May 28, 2025
@wilkinsona wilkinsona added type: bug A general bug and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels May 28, 2025
@wilkinsona wilkinsona added this to the 3.5.x milestone May 28, 2025
@snicoll snicoll modified the milestones: 3.5.x, 3.5.1 Jun 2, 2025
@snicoll snicoll self-assigned this Jun 2, 2025
@snicoll snicoll added the status: noteworthy A noteworthy issue to call out in the release notes label Jun 2, 2025
vegardlu added a commit to navikt/eux-adresse-oppdatering that referenced this issue Jun 3, 2025
@vegardlu
Spring boot bug: spring-projects/spring-boot#45673
c9a5e11
@snicoll snicoll closed this as completed in 8495722 Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
status: noteworthy A noteworthy issue to call out in the release notes type: bug A general bug
Projects
None yet
Milestone
3.5.1
Development

No branches or pull requests
5 participants
@snicoll @philwebb @wilkinsona @agebhar1 @spring-projects-issues