Skip to content

ManagementWebServerFactoryCustomizer and ManagementErrorPageCustomizer should not have the same order #45728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue May 30, 2025 · 1 comment
Closed

ManagementWebServerFactoryCustomizer and ManagementErrorPageCustomizer should not have the same order #45728

snicoll opened this issue May 30, 2025 · 1 comment
Assignees
@snicoll
Labels
type: bug A general bug
Milestone
3.4.7

Comments

@snicoll
Copy link
Member

snicoll commented May 30, 2025

This seems to have worked thus far by accident. They're both at order 0 and one is clearing the error pages while the other is registering an error page.

Flagging for team-attention as I am not sure where to fix this.
@snicoll snicoll added for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels May 30, 2025
@wilkinsona
Copy link
Member

I think we should fix it in 3.4.x and later.

@snicoll snicoll added type: bug A general bug and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels May 30, 2025
@snicoll snicoll added this to the 3.4.x milestone May 30, 2025
@snicoll snicoll self-assigned this May 30, 2025
@naveenprasanth2 naveenprasanth2 mentioned this issue May 31, 2025
Closed
naveenprasanth2 added a commit to naveenprasanth2/spring-boot that referenced this issue May 31, 2025
@naveenprasanth2
Merge remote-tracking branch 'origin/spring-projectsgh-45728-fix-cust…
1cc6c51 
…omizer-order' into spring-projectsgh-45728-fix-customizer-order
@naveenprasanth2 naveenprasanth2 mentioned this issue May 31, 2025
Closed
@snicoll snicoll modified the milestones: 3.4.x, 3.4.7 Jun 2, 2025
@snicoll snicoll mentioned this issue Jun 2, 2025
Closed
@snicoll snicoll closed this as completed in 3595c7a Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: bug A general bug
Projects
None yet
Milestone
3.4.7
2 participants
@snicoll @wilkinsona