Merge pull request #8 from sql-rb/operations-with-literals

Support operations with literals

Author: solnic

lib/sql/composer/dsl.rb

@@ -33,7 +33,7 @@ def call
       end
 
       def `(value)
-        Nodes::Literal.new(value: value)
+        Nodes::Literal.new(value: value, backend: options[:backend])
       end
 
       private

lib/sql/composer/nodes/identifier.rb

@@ -1,11 +1,15 @@
 # frozen_string_literal: true
 
 require "sql/composer/nodes/core"
+require "sql/composer/nodes/operators"
+
 
 module SQL
   module Composer
     module Nodes
       class Identifier < Core
+        include Operators
+
         def name
           fetch(:name).to_s
         end
@@ -29,19 +33,6 @@ def qualifier
         def qualify?
           options.key?(:qualifier)
         end
-
-        # this is probably a stupid idea lol
-        def ==(other)
-          value = Nodes::Value.new(input: other, backend: backend)
-
-          operation = Operations::Eql.new(left: self, right: value)
-
-          if other.start_with?("%") && other.end_with?("%")
-            tokens.add(other, value)
-          end
-
-          operation
-        end
       end
     end
   end

lib/sql/composer/nodes/literal.rb

@@ -1,11 +1,14 @@
 # frozen_string_literal: true
 
 require "sql/composer/nodes/core"
+require "sql/composer/nodes/operators"
 
 module SQL
   module Composer
     module Nodes
       class Literal < Core
+        include Operators
+
         def value
           fetch(:value)
         end

lib/sql/composer/nodes/operators.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+require "sql/composer/nodes/operations/eql"
+require "sql/composer/nodes/operations/order_direction"
+
+module SQL
+  module Composer
+    module Nodes
+      module Operators
+        def ==(other)
+          value = Nodes::Value.new(input: other, backend: backend)
+
+          operation = Operations::Eql.new(left: self, right: value)
+
+          if other.start_with?("%") && other.end_with?("%")
+            tokens.add(other, value)
+          end
+
+          operation
+        end
+
+        def asc
+          Operations::Asc.new(self)
+        end
+
+        def desc
+          Operations::Desc.new(self)
+        end
+      end
+    end
+  end
+end

spec/integration/sql/compose_spec.rb

@@ -45,6 +45,26 @@ def compose(&block)
       end
     end
 
+    context "with literals in WHERE" do
+      let(:query) do
+        compose {
+          SELECT `"users"."id"`, `"users"."name"`
+          FROM `"users"`
+          WHERE `"users"."name"` == 'Jane'
+        }
+      end
+
+      specify do
+        expect(result).to eql(
+          <<~SQL.strip
+            SELECT "users"."id", "users"."name"
+            FROM "users"
+            WHERE "users"."name" == 'Jane'
+          SQL
+        )
+      end
+    end
+
     context "inline syntax" do
       let(:query) do
         compose {