Merge pull request #289 from carlosms/i-288

Fix panic for malformed UAST unmarshal

Author: carlosms

server/service/uast.go

@@ -69,6 +69,10 @@ func UnmarshalUAST(data []byte) ([]*Node, error) {
 			return nil, ErrUnmarshalUAST.New(err)
 		}
 
+		if nodeLen < 1 {
+			return nil, ErrUnmarshalUAST.New(fmt.Errorf("malformed data"))
+		}
+
 		node := uast.NewNode()
 		nodeBytes := buf.Next(int(nodeLen))
 		if int32(len(nodeBytes)) != nodeLen {

server/service/uast_test.go

@@ -0,0 +1,31 @@
+package service_test
+
+import (
+	"bytes"
+	"encoding/binary"
+	"testing"
+
+	"github.com/src-d/gitbase-web/server/service"
+	"github.com/stretchr/testify/suite"
+)
+
+type UastSuite struct {
+	suite.Suite
+}
+
+func TestUastSuite(t *testing.T) {
+	s := new(UastSuite)
+	suite.Run(t, s)
+}
+
+func (suite *UastSuite) TestNegativeNodeLen() {
+	var nodeLen int32 = -20
+
+	buf := new(bytes.Buffer)
+	err := binary.Write(buf, binary.BigEndian, nodeLen)
+	suite.Require().NoError(err)
+
+	nodes, err := service.UnmarshalUAST(buf.Bytes())
+	suite.Require().Error(err)
+	suite.Require().Nil(nodes)
+}