Skip to content

Commit 922b67e

Browse files
authored
Various updates (#45)
* Various updates - Dependency updates - Log open files limit - Reduce logging at info slightly - Add rust-toolchain.toml - Fix pre-commit warnings * Various updates - Dep updates - Rust toolchain update - PR template update * rustfmt * Update dependencies * Update operator-rs * Update dependencies * better telemetry integration * rustfmt * rustfmt * use our version of cargo-udeps * pre-commit * pre-commit * add markdownlint config * add markdownlint & yamllint config * md lint * address review comment
1 parent 57365e8 commit 922b67e

15 files changed

+1123
-586
lines changed

.github/pull_request_template.md

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,23 +7,20 @@
77
- Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
88
- Please make sure all these things are done and tick the boxes
99

10-
```[tasklist]
11-
# Author
10+
### Author
11+
1212
- [ ] Changes are OpenShift compatible
1313
- [ ] Integration tests passed (for non trivial changes)
14-
```
1514

16-
```[tasklist]
17-
# Reviewer
15+
### Reviewer
16+
1817
- [ ] Code contains useful comments
1918
- [ ] (Integration-)Test cases added
2019
- [ ] Documentation added or updated
2120
- [ ] Changelog updated
2221
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
23-
```
2422

25-
```[tasklist]
26-
# Acceptance
23+
### Acceptance
24+
2725
- [ ] Feature Tracker has been updated
2826
- [ ] Proper release label has been added
29-
```

.github/workflows/build.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ env:
1717
CARGO_TERM_COLOR: always
1818
CARGO_INCREMENTAL: "0"
1919
CARGO_PROFILE_DEV_DEBUG: "0"
20-
RUST_TOOLCHAIN_VERSION: "1.82.0"
20+
RUST_TOOLCHAIN_VERSION: "1.85.0"
2121
RUSTFLAGS: "-D warnings"
2222
RUSTDOCFLAGS: "-D warnings"
2323
RUST_LOG: "info"
@@ -30,14 +30,14 @@ jobs:
3030
env:
3131
RUSTC_BOOTSTRAP: 1
3232
steps:
33-
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
33+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
3434
- uses: dtolnay/rust-toolchain@master
3535
with:
3636
toolchain: ${{ env.RUST_TOOLCHAIN_VERSION }}
3737
- uses: Swatinem/rust-cache@82a92a6e8fbeee089604da2575dc567ae9ddeaab # v2.7.5
3838
with:
3939
key: udeps
40-
- run: cargo install --locked cargo-udeps@0.1.50
40+
- uses: stackabletech/cargo-install-action@cargo-udeps
4141
- run: cargo udeps --all-targets --all-features
4242

4343
run_cargodeny:
@@ -53,7 +53,7 @@ jobs:
5353
continue-on-error: ${{ matrix.checks == 'advisories' }}
5454

5555
steps:
56-
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
56+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
5757
- uses: EmbarkStudios/cargo-deny-action@e2f4ede4a4e60ea15ff31bc0647485d80c66cfba # v2.0.4
5858
with:
5959
command: check ${{ matrix.checks }}
@@ -62,7 +62,7 @@ jobs:
6262
name: Run Rustfmt
6363
runs-on: ubuntu-latest
6464
steps:
65-
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
65+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
6666
- uses: dtolnay/rust-toolchain@master
6767
with:
6868
toolchain: ${{ env.RUST_TOOLCHAIN_VERSION }}
@@ -80,14 +80,14 @@ jobs:
8080
run: |
8181
sudo apt-get update
8282
sudo apt-get install protobuf-compiler krb5-user libkrb5-dev libclang-dev liblzma-dev libssl-dev pkg-config
83-
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
83+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
8484
with:
8585
submodules: recursive
8686
- uses: dtolnay/rust-toolchain@master
8787
with:
8888
toolchain: ${{ env.RUST_TOOLCHAIN_VERSION }}
8989
components: clippy
90-
- uses: Swatinem/rust-cache@82a92a6e8fbeee089604da2575dc567ae9ddeaab # v2.7.5
90+
- uses: Swatinem/rust-cache@9d47c6ad4b02e050fd481d890b2ea34778fd09d6 # v2.7.8
9191
with:
9292
key: clippy
9393
- name: Run clippy action to produce annotations
@@ -112,12 +112,12 @@ jobs:
112112
name: Run RustDoc
113113
runs-on: ubuntu-latest
114114
steps:
115-
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
115+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
116116
- uses: dtolnay/rust-toolchain@master
117117
with:
118118
toolchain: ${{ env.RUST_TOOLCHAIN_VERSION }}
119119
components: rustfmt
120-
- uses: Swatinem/rust-cache@82a92a6e8fbeee089604da2575dc567ae9ddeaab # v2.7.5
120+
- uses: Swatinem/rust-cache@9d47c6ad4b02e050fd481d890b2ea34778fd09d6 # v2.7.8
121121
with:
122122
key: doc
123123
- run: cargo doc --document-private-items
@@ -130,15 +130,15 @@ jobs:
130130
- run_rustdoc
131131
runs-on: ubuntu-latest
132132
steps:
133-
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
133+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
134134
- uses: dtolnay/rust-toolchain@master
135135
with:
136136
toolchain: ${{ env.RUST_TOOLCHAIN_VERSION }}
137137
# rust-src is required for trybuild stderr output comparison to work
138138
# for our cases.
139139
# See: https://github.com/dtolnay/trybuild/issues/236#issuecomment-1620950759
140140
components: rust-src
141-
- uses: Swatinem/rust-cache@82a92a6e8fbeee089604da2575dc567ae9ddeaab # v2.7.5
141+
- uses: Swatinem/rust-cache@9d47c6ad4b02e050fd481d890b2ea34778fd09d6 # v2.7.8
142142
with:
143143
key: test
144144
- run: cargo test --all-features

.github/workflows/daily_security.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
audit:
1111
runs-on: ubuntu-latest
1212
steps:
13-
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
13+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
1414
- uses: rustsec/audit-check@69366f33c96575abad1ee0dba8212993eecbe998 # v2.0.0
1515
with:
1616
token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/pr_pre-commit.yaml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,16 @@ on:
66

77
env:
88
CARGO_TERM_COLOR: always
9-
RUST_TOOLCHAIN_VERSION: "1.82.0"
10-
HADOLINT_VERSION: "v1.17.6"
9+
RUST_TOOLCHAIN_VERSION: "1.85.0"
1110

1211
jobs:
1312
pre-commit:
1413
runs-on: ubuntu-latest
1514
steps:
16-
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
15+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
1716
with:
1817
fetch-depth: 0
19-
- uses: stackabletech/actions/run-pre-commit@9bd13255f286e4b7a654617268abe1b2f37c3e0a # v0.3.0
18+
- uses: stackabletech/actions/run-pre-commit@9aae2d1c14239021bfa33c041010f6fb7adec815 # v0.8.2
2019
with:
2120
rust: ${{ env.RUST_TOOLCHAIN_VERSION }}
2221
# rust-src is required for trybuild stderr output comparison to work

.markdownlint.yaml

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
---
2+
# All defaults or options can be checked here:
3+
# https://github.com/DavidAnson/markdownlint/blob/main/schema/.markdownlint.yaml
4+
5+
# Default state for all rules
6+
default: true
7+
8+
# MD013/line-length - Line length
9+
MD013:
10+
# Number of characters
11+
line_length: 9999
12+
# Number of characters for headings
13+
heading_line_length: 9999
14+
# Number of characters for code blocks
15+
code_block_line_length: 9999
16+
17+
# MD033/no-inline-html
18+
MD033:
19+
allowed_elements: [h1, img, p]
20+
21+
# MD024/no-duplicate-heading/no-duplicate-header - Multiple headings with the same content
22+
MD024:
23+
# Only check sibling headings
24+
siblings_only: true

.pre-commit-config.yaml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ default_language_version:
44

55
repos:
66
- repo: https://github.com/pre-commit/pre-commit-hooks
7-
rev: 2c9f875913ee60ca25ce70243dc24d5b6415598c # 4.6.0
7+
rev: cef0300fd0fc4d2a87a85fa2093c6b283ea36f4b # 5.0.0
88
hooks:
99
- id: trailing-whitespace
1010
- id: end-of-file-fixer
@@ -19,13 +19,14 @@ repos:
1919
args: ["--all", "--", "--check"]
2020
- id: clippy
2121
args: ["--all-targets", "--", "-D", "warnings"]
22+
2223
- repo: https://github.com/adrienverge/yamllint
23-
rev: 81e9f98ffd059efe8aa9c1b1a42e5cce61b640c6 # 1.35.1
24+
rev: 79a6b2b1392eaf49cdd32ac4f14be1a809bbd8f7 # 1.37.1
2425
hooks:
2526
- id: yamllint
2627

2728
- repo: https://github.com/igorshubovych/markdownlint-cli
28-
rev: f295829140d25717bc79368d3f966fc1f67a824f # 0.41.0
29+
rev: 192ad822316c3a22fb3d3cc8aa6eafa0b8488360 # 0.45.0
2930
hooks:
3031
- id: markdownlint
3132

@@ -36,7 +37,7 @@ repos:
3637
args: ["--severity=info"]
3738

3839
- repo: https://github.com/rhysd/actionlint
39-
rev: 62dc61a45fc95efe8c800af7a557ab0b9165d63b # 1.7.1
40+
rev: 03d0035246f3e81f36aed592ffb4bebf33a03106 # 1.7.7
4041
hooks:
4142
- id: actionlint
4243

.yamllint.yaml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
---
2+
extends: default
3+
4+
ignore: |
5+
deploy/helm/**/templates
6+
7+
rules:
8+
line-length: disable
9+
truthy:
10+
check-keys: false
11+
comments:
12+
min-spaces-from-content: 1 # Needed due to https://github.com/adrienverge/yamllint/issues/443
13+
indentation:
14+
indent-sequences: consistent

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,10 @@ All notable changes to this project will be documented in this file.
77
### Changed
88

99
- Increased the default `--loop` interval from every minute to every 30 minutes ([#23]).
10+
- Collect and output the open files limit ([#45])
1011

1112
[#23]: https://github.com/stackabletech/containerdebug/pull/23
13+
[#45]: https://github.com/stackabletech/containerdebug/pull/45
1214

1315
## [0.1.1] - 2024-12-16
1416

0 commit comments

Comments
 (0)