diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 1c68660d..538ab251 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -7,24 +7,24 @@ - Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant - Please make sure all these things are done and tick the boxes -```[tasklist] -# Author +### Author + - [ ] Changes are OpenShift compatible - [ ] CRD changes approved +- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide). - [ ] Integration tests passed (for non trivial changes) -``` +- [ ] Changes need to be "offline" compatible + +### Reviewer -```[tasklist] -# Reviewer - [ ] Code contains useful comments +- [ ] Code contains useful logging statements - [ ] (Integration-)Test cases added -- [ ] Documentation added or updated +- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide). - [ ] Changelog updated - [ ] Cargo.toml only contains references to git tags (not specific commits or branches) -``` -```[tasklist] -# Acceptance +### Acceptance + - [ ] Feature Tracker has been updated - [ ] Proper release label has been added -``` diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 7a01a597..28136d91 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -4,7 +4,7 @@ default_language_version: repos: - repo: https://github.com/pre-commit/pre-commit-hooks - rev: 2c9f875913ee60ca25ce70243dc24d5b6415598c # 4.6.0 + rev: cef0300fd0fc4d2a87a85fa2093c6b283ea36f4b # 5.0.0 hooks: - id: trailing-whitespace - id: end-of-file-fixer @@ -18,12 +18,12 @@ repos: - id: clippy args: ["--all-targets", "--", "-D", "warnings"] - repo: https://github.com/adrienverge/yamllint - rev: 81e9f98ffd059efe8aa9c1b1a42e5cce61b640c6 # 1.35.1 + rev: 79a6b2b1392eaf49cdd32ac4f14be1a809bbd8f7 # 1.37.1 hooks: - id: yamllint - repo: https://github.com/igorshubovych/markdownlint-cli - rev: f295829140d25717bc79368d3f966fc1f67a824f # 0.41.0 + rev: 192ad822316c3a22fb3d3cc8aa6eafa0b8488360 # 0.45.0 hooks: - id: markdownlint @@ -34,7 +34,7 @@ repos: args: ["--severity=info"] - repo: https://github.com/rhysd/actionlint - rev: 62dc61a45fc95efe8c800af7a557ab0b9165d63b # 1.7.1 + rev: 03d0035246f3e81f36aed592ffb4bebf33a03106 # 1.7.7 hooks: - id: actionlint