NO-JIRA: pext/aws: get change domain from profile. Fix openshift#64080 (openshift#64346)

Author: mtulio

ci-operator/step-registry/opct/conformance/external-aws/opct-conformance-external-aws-workflow.yaml

@@ -16,7 +16,6 @@ workflow:
     env:
       PROVIDER_NAME: aws
       PLATFORM_EXTERNAL_CCM_ENABLED: no
-      BASE_DOMAIN: origin-ci-int-aws.dev.rhcloud.com
       OPCT_CLI_IMAGE: "quay.io/opct/opct:v0.6.0"
   documentation: |-
     The OPCT Conformance External E2E workflow executes the common end-to-end test suite using

ci-operator/step-registry/openshift/e2e/external/aws/clusterbot/openshift-e2e-external-aws-clusterbot-workflow.yaml

@@ -11,6 +11,5 @@ workflow:
     env:
       PROVIDER_NAME: aws
       PLATFORM_EXTERNAL_CCM_ENABLED: no
-      BASE_DOMAIN: origin-ci-int-aws.dev.rhcloud.com
   documentation: |-
     The origin E2E workflow to validate clusters installed on AWS with platform type external with clusterbot.

ci-operator/step-registry/openshift/e2e/external/aws/openshift-e2e-external-aws-workflow.yaml

@@ -14,7 +14,6 @@ workflow:
     env:
       PROVIDER_NAME: aws
       PLATFORM_EXTERNAL_CCM_ENABLED: no
-      BASE_DOMAIN: origin-ci-int-aws.dev.rhcloud.com
       # FIXME: The following test skips must be removed once the issue is fixed.
       # HAProxy: https://issues.redhat.com/browse/SPLAT-2089
       # [sig-network] LoadBalancers:

ci-operator/step-registry/platform-external/pre/conf/platform-external-pre-conf-commands.sh

@@ -4,8 +4,6 @@ set -o nounset
 set -o errexit
 set -o pipefail
 
-echo "Using release image ${OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE}"
-
 #
 # Enable CCM
 #
@@ -42,12 +40,22 @@ if [[ "${PLATFORM_EXTERNAL_CCM_ENABLED-}" == "yes" ]]; then
   CONFIG_PLATFORM_EXTERNAL_CCM="External"
 fi
 
+# Setting the baseDomain from profile or leave the default.
+#
+if [[ -r "${CLUSTER_PROFILE_DIR}/baseDomain" ]]; then
+  CLUSTER_BASE_DOMAIN=$(< ${CLUSTER_PROFILE_DIR}/baseDomain)
+  echo "Using baseDomain from CI Profile, value: ${CLUSTER_BASE_DOMAIN}"
+else
+  CLUSTER_BASE_DOMAIN="${BASE_DOMAIN}"
+  echo "Using baseDomain from default,value: ${BASE_DOMAIN}"
+fi
+
 #
-# Render the install-config.yaml
+# Patch the install-config.yaml
 #
 log "Creating install-config.yaml patch"
 cat > "${PATCH}" << EOF
-baseDomain: ${BASE_DOMAIN}
+baseDomain: ${CLUSTER_BASE_DOMAIN}
 platform:
   external:
     platformName: ${PROVIDER_NAME}

ci-operator/step-registry/platform-external/pre/conf/platform-external-pre-conf-ref.yaml

@@ -8,12 +8,9 @@ ref:
       cpu: 10m
       memory: 100Mi
   documentation: |-
-    The IPI AWS configure step generates the AWS-specific install-config.yaml contents based on the cluster profile and optional input files.
-  dependencies:
-    - name: "release:latest"
-      env: OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE
-    - name: "release:initial"
-      env: OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE
+    The configure step generates the install-config.yaml for the platform
+    type External cluster for a standard OpenShift topology.
+    The contents based on the cluster profile and optional job-level configuration.
   env:
   - name: PROVIDER_NAME
     default: ""
@@ -24,9 +21,11 @@ ref:
     documentation: |-
       When set to "yes" the CCM parameters will be set in the install-config.yaml.
   - name: BASE_DOMAIN
-    default: ""
+    default: "origin-ci-int-aws.dev.rhcloud.com"
     documentation: |-
-      A fully-qualified domain or subdomain name. The base domain of the cloud provider is used for setting baseDomain variable of the install configuration of the cluster.
+      A fully-qualified domain or subdomain name to fallback from cluster-profile.
+      The base domain of the cloud provider is used for setting baseDomain variable
+      of the install configuration of the cluster.
   - name: PLATFORM_EXTERNAL_OVERRIDE_RELEASE
     default: ""
     documentation: |-