Skip to content

Commit 283a78d

Browse files
authored
Improve input page
Fix URI encoding, add counter for length of URI with encoded input as query string, validate input size and make it transparent when client cert is in use.
1 parent a7f4631 commit 283a78d

13 files changed

+605
-107
lines changed

Diff for: README.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,11 @@ Starfish is in active development. It currently supports the prerelease version
2121

2222
## Build
2323

24-
Starfish is built for elementary OS 6. All prerequisites can be met by installing `elementary-sdk`:
24+
Starfish is built for elementary OS 6. All prerequisites can be met by installing `elementary-sdk` and `gtkspell`:
2525

2626
```sh
2727
sudo apt install elementary-sdk
28+
sudo apt install libgtkspell3-3-dev
2829
```
2930

3031
For a full list of dependencies check out the `dependencies` list in the [meson.build file](meson.build#L11-L20).

Diff for: data/TextViewHighlighter.css

+35
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
.highlighter {
2+
background-color: @base_color;
3+
background-clip: padding-box;
4+
border: 1px solid alpha(black, 0.3);
5+
/*border-radius: calc(100%/3 - 2*1em - 2*1px);*/
6+
border-radius: calc(((3/96) / (9/72)) * 1rem + 0.000000001rem);
7+
/*border-radius: calc(3px / 9pt * 1rem);*/
8+
box-shadow: 0 1px 0 0 alpha(@highlight_color, 0.3),
9+
inset 0 1px 1px alpha(black, 0.05),
10+
inset 0 0 1px 1px alpha(black, 0.05);
11+
margin: calc(((4/96) / (9/72)) * 1rem + 0.000000001rem);
12+
}
13+
14+
.highlighter.light {
15+
border: 1px solid alpha(black, 0.2);
16+
}
17+
18+
.highlighter.focus {
19+
box-shadow: 0 0 0 calc(((2/96) / (9/72)) * 1rem + 0.000000001rem) alpha(@accent_color, 0.3),
20+
0 1px 0 0 alpha(@highlight_color, 0.3),
21+
inset 0 1px 1px alpha(black, 0.05),
22+
inset 0 0 1px 1px alpha(black, 0.05);
23+
}
24+
25+
.highlighter.focus.light {
26+
border-color: @accent_color;
27+
}
28+
29+
.highlighter textview {
30+
background-color: transparent;
31+
}
32+
33+
.highlighter.error :first-child :first-child {
34+
color: @error_color
35+
}

Diff for: data/gresource.xml

+3
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,7 @@
33
<gresource prefix="/hr/from/josipantolis/starfish">
44
<file compressed="true">AddressEntry.css</file>
55
</gresource>
6+
<gresource prefix="/hr/from/josipantolis/starfish">
7+
<file compressed="true">TextViewHighlighter.css</file>
8+
</gresource>
69
</gresources>

Diff for: hr.from.josipantolis.starfish.yml

+17
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,23 @@ finish-args:
1414
# Nedded for perfer-color-scheme
1515
- '--system-talk-name=org.freedesktop.Accounts'
1616
modules:
17+
- name: gtkspell
18+
config-opts:
19+
- '--disable-gtk-doc-html'
20+
cleanup:
21+
- '/share/gtk-doc' # for some reason, it still install the html folder.
22+
sources:
23+
- type: archive
24+
url: https://downloads.sourceforge.net/gtkspell/gtkspell3-3.0.10.tar.xz
25+
sha256: b040f63836b347eb344f5542443dc254621805072f7141d49c067ecb5a375732
26+
modules:
27+
- name: intltool
28+
cleanup:
29+
- '*'
30+
sources:
31+
- type: archive
32+
url: https://launchpad.net/intltool/trunk/0.51.0/+download/intltool-0.51.0.tar.gz
33+
md5: 12e517cac2b57a0121cda351570f1e63
1734
- name: starfish
1835
buildsystem: meson
1936
sources:

Diff for: meson.build

+2
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ dependencies = [
1616
dependency('granite'),
1717
dependency('libhandy-1'),
1818
dependency('gnutls'),
19+
dependency('gtkspell3-3.0'),
1920
meson.get_compiler('vala').find_library('posix'),
2021
]
2122

@@ -49,6 +50,7 @@ sources = gresource + files(
4950
'src/UI/LinkEventType.vala',
5051
'src/UI/LinkEvent.vala',
5152
'src/UI/TabContent.vala',
53+
'src/UI/TextViewHighlighter.vala',
5254
'src/Templates/Template.vala',
5355
'src/Templates/Bookmarks.vala',
5456
'src/Templates/TempFailure.vala',

Diff for: po/POTFILES

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ src/UI/PageDownloadView.vala
1515
src/UI/LinkEventType.vala
1616
src/UI/LinkEvent.vala
1717
src/UI/TabContent.vala
18+
src/UI/TextViewHighlighter.vala
1819
src/Templates/Template.vala
1920
src/Templates/Bookmarks.vala
2021
src/Templates/TempFailure.vala

0 commit comments

Comments
 (0)