From 26ebd6f4c64eac64bfa26e602ea760a781d452b4 Mon Sep 17 00:00:00 2001 From: Vladimir Sumarov Date: Tue, 4 Feb 2025 16:14:57 -0800 Subject: [PATCH 1/2] update aws sdk version --- .github/workflows/build.yml | 2 +- README.md | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0d83919..6055776 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -21,7 +21,7 @@ env: RELEASE_BUCKET: "slobs-crash-handler" ELECTRON_VERSION: "v29.4.3" BIN_DEPENDENCIES: "dependencies2019.0" - AWS_SDK_VERSION: "1.11.367" + AWS_SDK_VERSION: "1.11.492" AWS_SDK_PATH: "aws-sdk/awsi" permissions: diff --git a/README.md b/README.md index 2a338f1..bc89a47 100644 --- a/README.md +++ b/README.md @@ -9,12 +9,14 @@ yarn install set BIN_DEPENDENCIES=dependencies2019.0 ci\install-bin-deps.cmd -set AWS_SDK_VERSION="1.11.367" +set AWS_SDK_VERSION="1.11.492" ci\build-aws-sdk.cmd ci\localization_prepare_binaries.cmd +set AWS_CRASH_UPLOAD_BUCKET_KEY=your_aws_bucket_key_for_memory_dumps set INSTALL_PACKAGE_PATH="../desktop/node_modules/crash-handler" + cmake -B"build" -G"Visual Studio 17 2022" -A x64 -DDepsPath="%CD%\build\deps\%BIN_DEPENDENCIES%\win64" -DBOOST_ROOT="%CD%\build\deps\boost" -DCMAKE_INSTALL_PREFIX="%INSTALL_PACKAGE_PATH%" cmake --build "build" --target install --config RelWithDebInfo ``` From 6f9cb4e2aeb63e4072c5977ca9fb3f7c8b62e42a Mon Sep 17 00:00:00 2001 From: Vladimir Sumarov Date: Wed, 5 Feb 2025 17:09:29 -0800 Subject: [PATCH 2/2] workaround for win ssl bug --- .github/workflows/build.yml | 2 +- README.md | 2 +- crash-handler-process/platforms/util-win.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 6055776..3ebc9b8 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -21,7 +21,7 @@ env: RELEASE_BUCKET: "slobs-crash-handler" ELECTRON_VERSION: "v29.4.3" BIN_DEPENDENCIES: "dependencies2019.0" - AWS_SDK_VERSION: "1.11.492" + AWS_SDK_VERSION: "1.11.500" AWS_SDK_PATH: "aws-sdk/awsi" permissions: diff --git a/README.md b/README.md index bc89a47..e43f090 100644 --- a/README.md +++ b/README.md @@ -9,7 +9,7 @@ yarn install set BIN_DEPENDENCIES=dependencies2019.0 ci\install-bin-deps.cmd -set AWS_SDK_VERSION="1.11.492" +set AWS_SDK_VERSION="1.11.500" ci\build-aws-sdk.cmd ci\localization_prepare_binaries.cmd diff --git a/crash-handler-process/platforms/util-win.cpp b/crash-handler-process/platforms/util-win.cpp index b65df29..feb8214 100644 --- a/crash-handler-process/platforms/util-win.cpp +++ b/crash-handler-process/platforms/util-win.cpp @@ -561,7 +561,7 @@ bool Util::uploadToAWS(const std::wstring &wspath, const std::wstring &fileName) config.region = region; } config.scheme = Aws::Http::Scheme::HTTPS; - config.verifySSL = false; + config.verifySSL = true; config.followRedirects = Aws::Client::FollowRedirectsPolicy::NEVER; Aws::Auth::AWSCredentials aws_credentials; aws_credentials.SetAWSAccessKeyId(accessIDKey);