Skip to content

Commit 5435da4

Browse files
authored
Revert "Migrate video settings to realm and remove video settings service. (#…" (#5365)
This reverts commit cf49fcc.
1 parent eb81bbd commit 5435da4

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+1273
-1564
lines changed

app/app-services.ts

+3
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ export { HighlighterService } from 'services/highlighter';
5858
export { DiagnosticsService } from 'services/diagnostics';
5959
export { RecordingModeService } from 'services/recording-mode';
6060
export { SideNavService } from 'services/side-nav';
61+
export { VideoSettingsService } from 'services/settings-v2/video';
6162
export { SettingsManagerService } from 'services/settings-manager';
6263
export { MarkersService } from 'services/markers';
6364
export { RealmService } from 'services/realm';
@@ -199,6 +200,7 @@ import { PlatformAppStoreService } from 'services/platform-app-store';
199200
import { GameOverlayService } from 'services/game-overlay';
200201
import { GuestCamService } from 'services/guest-cam';
201202
import { SideNavService } from './services/side-nav';
203+
import { VideoSettingsService } from 'services/settings-v2/video';
202204
import { SettingsManagerService } from 'services/settings-manager';
203205
import { DualOutputService } from 'services/dual-output';
204206
import { MarkersService } from 'services/markers';
@@ -282,6 +284,7 @@ export const AppServices = {
282284
GuestCamService,
283285
HardwareService,
284286
SideNavService,
287+
VideoSettingsService,
285288
SettingsManagerService,
286289
DualOutputService,
287290
MarkersService,

app/components-react/root/StudioEditor.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import cx from 'classnames';
66
import Display from 'components-react/shared/Display';
77
import { $t } from 'services/i18n';
88
import { ERenderingMode } from '../../../obs-api';
9-
import { TDisplayType } from 'services/video';
9+
import { TDisplayType } from 'services/settings-v2';
1010
import AutoProgressBar from 'components-react/shared/AutoProgressBar';
1111
import { useSubscription } from 'components-react/hooks/useSubscription';
1212
import { message } from 'antd';

app/components-react/shared/Display.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import React, { useEffect, useRef } from 'react';
22
import { useVuex } from '../hooks';
33
import { Services } from '../service-provider';
44
import { Display as OBSDisplay } from '../../services/video';
5-
import { TDisplayType } from 'services/video';
5+
import { TDisplayType } from 'services/settings-v2/video';
66
import uuid from 'uuid/v4';
77
import { useRealmObject } from 'components-react/hooks/realm';
88
interface DisplayProps {
@@ -18,7 +18,7 @@ interface DisplayProps {
1818
}
1919

2020
export default function Display(props: DisplayProps) {
21-
const { CustomizationService, VideoService } = Services;
21+
const { CustomizationService, VideoSettingsService } = Services;
2222

2323
const p = {
2424
paddingSize: 0,
@@ -30,7 +30,7 @@ export default function Display(props: DisplayProps) {
3030
};
3131

3232
const v = useVuex(() => {
33-
const videoSettings = VideoService.baseResolutions[p.type];
33+
const videoSettings = VideoSettingsService.baseResolutions[p.type];
3434

3535
return {
3636
baseResolution: `${videoSettings?.baseWidth}x${videoSettings?.baseHeight}`,

app/components-react/shared/DisplaySelector.tsx

+3-7
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
import React, { CSSProperties } from 'react';
22
import { $t } from 'services/i18n';
33
import { RadioInput } from './inputs';
4-
import { TDisplayType } from 'services/video';
5-
import { platformLabels, TPlatform } from 'services/platforms';
4+
import { TDisplayType } from 'services/settings-v2';
5+
import { TPlatform } from 'services/platforms';
66
import { useGoLiveSettings } from 'components-react/windows/go-live/useGoLiveSettings';
7-
import { ICustomStreamDestination } from 'services/settings/streaming';
87

98
interface IDisplaySelectorProps {
109
title: string;
@@ -24,9 +23,6 @@ export default function DisplaySelector(p: IDisplaySelectorProps) {
2423
} = useGoLiveSettings();
2524

2625
const setting = p.platform ? platforms[p.platform] : customDestinations[p.index];
27-
const label = p.platform
28-
? platformLabels(p.platform)
29-
: (setting as ICustomStreamDestination).name;
3026

3127
const displays = [
3228
{
@@ -44,7 +40,7 @@ export default function DisplaySelector(p: IDisplaySelectorProps) {
4440
data-test="display-input"
4541
id={`${p.platform}-display-input`}
4642
direction="horizontal"
47-
label={label}
43+
label={p.label}
4844
labelAlign="left"
4945
labelCol={{ offset: 0 }}
5046
colon

app/components-react/windows/go-live/useGoLiveSettings.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import { injectState, useModule } from 'slap';
1111
import { useForm } from '../../shared/inputs/Form';
1212
import { getDefined } from '../../../util/properties-type-guards';
1313
import isEqual from 'lodash/isEqual';
14-
import { TDisplayType } from 'services/video';
14+
import { TDisplayType } from 'services/settings-v2';
1515

1616
type TCommonFieldName = 'title' | 'description';
1717

app/components-react/windows/settings/HotkeyGroup.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { Collapse } from 'antd';
33
import cx from 'classnames';
44
import { IHotkey } from 'services/hotkeys';
55
import Hotkey from './Hotkey';
6-
import { TDisplayType } from 'services/video';
6+
import { TDisplayType } from 'services/settings-v2';
77
import Tabs from 'components-react/shared/Tabs';
88
import { $t } from 'services/i18n';
99

0 commit comments

Comments
 (0)