Skip to content

[question][licensing] Forking this project to use as Zed extension #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
florian-sanders opened this issue Nov 9, 2024 · 0 comments

Comments

@florian-sanders
Copy link

florian-sanders commented Nov 9, 2024

Context

I'm currently working on an extension for the Zed editor to provide LSP features for Stylelint (see zed-stylelint).

Since the language server is not a standalone project (see #110), I decided to fork this repo to provide a prebuilt (build + bundle) version of this package (see vscode-stylelint-prebuilt).

Questions

  • Is the fork acceptable as long as this project is legitimately credited? I'm asking because I do realize that this repo is designed for a VSCode extension and I'm using it for Zed so maybe that's not something you are okay with?
  • Is Publish server part as a separate stylelint-language-server #110 still on the roadmap? If you need help I could try to help (after some time to get up to speed)
  • Have you considered publishing the built + bundled code (extension code + language server) on npm? I've seen a few vscode LSP extensions doing that and it makes it easier to port them to other code editors. For instance this would remove the need for the fork in my case 🤔
maxdeviant pushed a commit to zed-industries/extensions that referenced this issue Feb 28, 2025
Fixes #1648

- This PR adds an extension to wrap `stylelint` LSP,
- [Stylelint](https://stylelint.io/) is used to lint CSS content in
files that support it (CSS, SCSS, JS, etc.),
- The [VSCode Stylelint
Extension](https://marketplace.visualstudio.com/items?itemName=stylelint.vscode-stylelint)
is fairly popular with more than 2,595,360 installs,
- The LSP server comes from the
[stylelint/vscode-stylelint](https://github.com/stylelint/vscode-stylelint)
project but there are few things to note:
- the GitHub repository contains both the LSP server and the VSCode
extension code,
- the LSP server is not entirely decoupled from VSCode extension code
but it does work on it's own,
  - neither the LSP Server or the VSCode are published as npm packages,
- the source code needs to be built (TypeScript project) & bundled to be
used,
- I had to fork the original repository so that I could:
- build & bundle the source code using the povided `build-bundle`
command (see [source
package.json](https://github.com/stylelint/vscode-stylelint/blob/main/package.json#L257C12-L257C180)
for more info),
- publish it as an npm package:
https://www.npmjs.com/package/@florian-sanders/vscode-stylelint-prebundled.

## About the fork & npm package

I don't mind maintaining the fork & npm package but I'd definitely be
okay to make it less about me and more about Zed or the community.
I chose to publish the LSP package in the `@florian-sanders` scope on
npm just because I wanted to make it clear that it was not officially
published by the Stylelint team but I'm open to other options.

For what it's worth, I have created an issue on the source repository to
ask:
- if it was okay to fork (license allows it but just in case),
- if they are still planning on decoupling the server & extension code,
- if they plan on publishing the server as a standalone package.

You can follow the discussions here:
stylelint/vscode-stylelint#623
For now nobody has answered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant