Skip to content

Commit 46d765c

Browse files
PaliCpytorchmergebot
authored andcommitted
[devX] make labels only count their own occurences (pytorch#98551)
Small QoL improvement such that add_numbered_label now works more intuitively. Now if we push different labels instead of having `[reverted, mergedX2, revertX3, mergedX4, revertedX5, mergedX6]` we have `[reverted, merged, revertX2, mergedX2, revertedX3, mergedX3]` Pull Request resolved: pytorch#98551 Approved by: https://github.com/huydhn
1 parent d06662f commit 46d765c

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

.github/scripts/trymerge.py

+8-6
Original file line numberDiff line numberDiff line change
@@ -1040,12 +1040,14 @@ def gen_commit_message(self, filter_ghstack: bool = False) -> str:
10401040
return msg
10411041

10421042
def add_numbered_label(self, label_base: str) -> None:
1043-
labels = self.get_labels()
1044-
label = label_base
1045-
for i in range(len(labels) if labels is not None else 0):
1046-
if label in labels:
1047-
label = f"{label_base}X{i+2}"
1048-
gh_add_labels(self.org, self.project, self.pr_num, [label])
1043+
labels = self.get_labels() if self.labels is not None else []
1044+
full_label = label_base
1045+
count = 0
1046+
for label in labels:
1047+
if label_base in label:
1048+
count += 1
1049+
full_label = f"{label_base}X{count}"
1050+
gh_add_labels(self.org, self.project, self.pr_num, [full_label])
10491051

10501052
def remove_label(self, label: str) -> None:
10511053
if self.get_labels() is not None and label in self.get_labels():

0 commit comments

Comments
 (0)