fix: vscode settings relative path (#11)

Author: juleswritescode

.vscode/launch.json

@@ -44,6 +44,20 @@
       "outFiles": ["${workspaceFolder}/out/**/*.js"],
       "sourceMapRenames": true
     },
+    {
+      "name": "🧩 Debug Extension (VSCode Settings Strategy)",
+      "type": "extensionHost",
+      "request": "launch",
+      "args": [
+        "--disable-extensions",
+        "--extensionDevelopmentKind=node",
+        "--extensionDevelopmentPath=${workspaceFolder}",
+        "--log=supabase.postgrestools-vscode:debug",
+        "${workspaceFolder}/test/fixtures/vscode-settings-strat"
+      ],
+      "outFiles": ["${workspaceFolder}/out/**/*.js"],
+      "sourceMapRenames": true
+    },
     {
       "name": "🧩 Debug Extension (Simple Project Global Binary)",
       "type": "extensionHost",

src/binary-finder-strategies.ts

@@ -70,7 +70,7 @@ export const vsCodeSettingsStrategy: BinaryFindStrategy = {
       logger.debug("Binary Setting is a string", { binSetting });
 
       const resolvedPath = binSetting.startsWith(".")
-        ? Uri.joinPath(path, binSetting).toString()
+        ? Uri.joinPath(path, binSetting).fsPath
         : binSetting;
 
       logger.debug("Looking for binary at path", { resolvedPath });

src/session.ts

@@ -43,6 +43,15 @@ export const createSession = async (
     return;
   }
 
+  if (!fileIsExecutable(findResult.bin)) {
+    window.showErrorMessage(`
+      The binary you've pointed to is not executable.
+      (${findResult.bin.fsPath})
+    `);
+    logger.error("Found binary is not executable.");
+    return;
+  }
+
   logger.info("Copying binary to temp location", {
     currentLocation: findResult.bin.fsPath,
   });
@@ -96,6 +105,8 @@ const copyBinaryToTemporaryLocation = async (
     .split(":")[1]
     .trim();
 
+  logger.debug(`Retrieved version from binary`, { version });
+
   const location = Uri.joinPath(
     state.context.globalStorageUri,
     "tmp-bin",

test/fixtures/vscode-settings-strat/.gitignore

@@ -0,0 +1 @@
+bin/*

test/fixtures/vscode-settings-strat/.vscode/settings.json

@@ -0,0 +1,4 @@
+{
+  "postgrestools.bin": "./bin/postgrestools"
+  // "postgrestools.bin": "/bin/postgrestools"
+}

test/fixtures/vscode-settings-strat/README.md

@@ -0,0 +1,18 @@
+# VSCode Settings Strategy
+
+A bread-and-butter project with a `postgrestools.jsonc` on top level and SQL files in the `test` folder.
+The goal is to let the `.vscode/settings.json` point to a binary and have that config working correctly.
+
+## Expectations
+
+The extension should recognize the `postgrestools.jsonc` file and connect with the right database. It should work when opening the `src/test.sql` file.
+
+## Test protocol
+
+### Via VSCode Settings
+
+0. Follow the instructions in `GLOBAL_SETUP.md`.
+1. Download a matching [postgrestools binary](https://github.com/supabase-community/postgres_lsp/releases/latest) and move it into `./bin`.
+2. Open the `.vscode/settings.json` and point to the binary, either via an absolute path or a relative path.
+3. You should not be prompted for any binary installations.
+4. The extension should work when you open the `src/test.sql` file.

test/fixtures/vscode-settings-strat/postgrestools.jsonc

@@ -0,0 +1,24 @@
+{
+  "vcs": {
+    "enabled": false,
+    "clientKind": "git",
+    "useIgnoreFile": false
+  },
+  "files": {
+    "ignore": []
+  },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true
+    }
+  },
+  "db": {
+    "host": "127.0.0.1",
+    "port": 3333,
+    "username": "postgres",
+    "password": "example",
+    "database": "postgres",
+    "connTimeoutSecs": 10
+  }
+}

test/fixtures/vscode-settings-strat/src/test.sql

@@ -0,0 +1 @@
+select * from users;