npx sv migrate app-state only migrates some files

[benmccann]

Run it in the web directory of https://github.com/immich-app/immich and it won't migrate anything. Some stuff was already migrated in immich-app/immich#14807, but it only got 9 out of 22 occurrences of $app/stores

[manuel3108]

Here is a failing test (note the word page in an unrelated import). I tried fixing the bug but failed.

test('Updates $app/store #4', () => {
	const result = transform_svelte_code(
		`<script>
	import { page } from '$app/stores';
	import Comp from '$lib/page/Comp.svelte'
</script>

<div>{$page.url}</div>
<button onclick={() => {
	console.log($page.state);
}}></button>
`
	);
	assert.equal(
		result,
		`<script>
	import { page } from '$app/state';
	import Comp from '$lib/page/Comp.svelte'
</script>

<div>{page.url}</div>
<button onclick={() => {
	console.log(page.state);
}}></button>
`
	);
});

FYI @dummdidumm

[ranjan-purbey]

I think it fails due to this line:

cli/packages/migrate/migrations/app-state/migrate.js

Line 70 in e325bb2

return code;

Here we return early and skip the migration if the imported store alias is not prefixed with a $, unless a few conditions are met. We probably need to add another condition here (while checking for false positives) to check if the alias is part of a string or a comment.

For e.g., if a component has the following line, it won't be migrated according to the current logic:

const str = "before page after";

or

// this is a page

[garikAsplund]

One thing I noticed when working on #494 was that if I ran the migration on a newly created project it would work great. However, when I changed an $app/state back to $app/stores after the initial migration, subsequent runs wouldn't fix it.

I don't know if that helps pinpoint any issues here or just muddies the waters.

[manuel3108]

That's because the word page will appear already, and that messes with the script somehow. This is basically also the testcase i mentioned above.