Skip to content

Commit 14c96c5

Browse files
committed
Use Vite to do all bundling
1 parent 2d80e94 commit 14c96c5

File tree

9 files changed

+32
-32
lines changed

9 files changed

+32
-32
lines changed

examples/hn.svelte.dev/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
},
1111
"devDependencies": {
1212
"@sveltejs/adapter-netlify": "workspace:*",
13+
"@sveltejs/adapter-node": "workspace:*",
1314
"@sveltejs/kit": "workspace:*",
1415
"svelte": "^3.43.1"
1516
}
Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
1-
import netlify from '@sveltejs/adapter-netlify';
2-
31
export default {
42
kit: {
5-
adapter: netlify(),
3+
adapter: '@sveltejs/adapter-node',
64
target: '#svelte'
75
}
86
};

packages/adapter-node/package.json

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,7 @@
88
},
99
"homepage": "https://kit.svelte.dev",
1010
"type": "module",
11-
"exports": {
12-
".": {
13-
"import": "./index.js"
14-
},
15-
"./package.json": "./package.json"
16-
},
17-
"main": "index.js",
18-
"types": "index.d.ts",
19-
"files": [
20-
"files",
21-
"index.d.ts"
22-
],
11+
"main": "files/index.js",
2312
"scripts": {
2413
"dev": "rollup -cw",
2514
"build": "rollup -c",

packages/adapter-node/rollup.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export default [
2121
sourcemap: true
2222
},
2323
plugins: [nodeResolve(), commonjs(), json()],
24-
external: ['./middlewares.js', './env.js', ...require('module').builtinModules]
24+
external: ['./middlewares.js', '../output/server/app.js', ...require('module').builtinModules]
2525
},
2626
{
2727
input: 'src/shims.js',

packages/adapter-node/src/env.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
export const path = process.env['PATH'] || false;
2+
export const host = process.env['HOST'] || '0.0.0.0';
3+
export const port = process.env['PORT'] || (!path && 3000);

packages/adapter-node/src/index.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
// @ts-ignore
2-
import { path, host, port } from './env.js';
3-
import { assetsMiddleware, kitMiddleware, prerenderedMiddleware } from './middlewares.js';
1+
import { path, host, port } from './env';
2+
import { assetsMiddleware, kitMiddleware, prerenderedMiddleware } from './middlewares';
43
import compression from 'compression';
54
import polka from 'polka';
65

packages/kit/src/core/build/index.js

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
import fs from 'fs';
2+
import { createRequire } from 'module';
23
import path from 'path';
3-
44
import { svelte } from '@sveltejs/vite-plugin-svelte';
55
import glob from 'tiny-glob/sync.js';
66
import vite from 'vite';
77

88
import { rimraf } from '../../utils/filesystem.js';
99
import { deep_merge } from '../../utils/object.js';
10-
1110
import { print_config_conflicts } from '../config/index.js';
1211
import { create_app } from '../create_app/index.js';
1312
import create_manifest_data from '../create_manifest_data/index.js';
@@ -17,11 +16,13 @@ import { copy_assets, posixify, resolve_entry } from '../utils.js';
1716
/** @param {any} value */
1817
const s = (value) => JSON.stringify(value);
1918

20-
/** @typedef {Record<string, {
19+
/**
20+
* @typedef {Record<string, {
2121
* file: string;
2222
* css: string[];
2323
* imports: string[];
24-
* }>} ClientManifest */
24+
* }>} ClientManifest
25+
*/
2526

2627
/**
2728
* @param {import('types/config').ValidatedConfig} config
@@ -464,6 +465,13 @@ async function build_server(
464465
// don't warn on overriding defaults
465466
const [modified_vite_config] = deep_merge(default_config, vite_config);
466467

468+
const adapter = config.kit.adapter;
469+
const require = createRequire(import.meta.url);
470+
const pkg_path = require.resolve(`${adapter}/package.json`);
471+
const pkg = JSON.parse(fs.readFileSync(pkg_path, 'utf8'));
472+
const main = path.resolve(pkg_path.substring(0, pkg_path.lastIndexOf('/')), pkg.main);
473+
console.log(`main ${main}`);
474+
467475
/** @type {[any, string[]]} */
468476
const [merged_config, conflicts] = deep_merge(modified_vite_config, {
469477
configFile: false,
@@ -476,7 +484,7 @@ async function build_server(
476484
polyfillDynamicImport: false,
477485
rollupOptions: {
478486
input: {
479-
app: app_file
487+
app: main
480488
},
481489
output: {
482490
format: 'esm',

packages/kit/src/core/config/options.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,16 @@ const options = object(
2424

2525
kit: object({
2626
adapter: validate(null, (input, keypath) => {
27-
if (typeof input !== 'object' || !input.adapt) {
28-
let message = `${keypath} should be an object with an "adapt" method`;
27+
// if (typeof input !== 'object' || !input.adapt) {
28+
// let message = `${keypath} should be an object with an "adapt" method`;
2929

30-
if (Array.isArray(input) || typeof input === 'string') {
31-
// for the early adapter adopters
32-
message += ', rather than the name of an adapter';
33-
}
30+
// if (Array.isArray(input) || typeof input === 'string') {
31+
// // for the early adapter adopters
32+
// message += ', rather than the name of an adapter';
33+
// }
3434

35-
throw new Error(`${message}. See https://kit.svelte.dev/docs#adapters`);
36-
}
35+
// throw new Error(`${message}. See https://kit.svelte.dev/docs#adapters`);
36+
// }
3737

3838
return input;
3939
}),

pnpm-lock.yaml

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)