From c3192eba18b0faa26450b05fe921934fd8157847 Mon Sep 17 00:00:00 2001 From: HoldYourWaffle Date: Tue, 15 Apr 2025 16:12:54 +0200 Subject: [PATCH 1/4] chore: remove test artifact Introduced by #6811, probably an accident? --- .../writes/src/routes/new-route/zzzz1662642734866/+page.svelte | 1 - 1 file changed, 1 deletion(-) delete mode 100644 packages/kit/test/apps/writes/src/routes/new-route/zzzz1662642734866/+page.svelte diff --git a/packages/kit/test/apps/writes/src/routes/new-route/zzzz1662642734866/+page.svelte b/packages/kit/test/apps/writes/src/routes/new-route/zzzz1662642734866/+page.svelte deleted file mode 100644 index ed6399be5c7d..000000000000 --- a/packages/kit/test/apps/writes/src/routes/new-route/zzzz1662642734866/+page.svelte +++ /dev/null @@ -1 +0,0 @@ -

Hello new route

From 6018554933fb4fd5daccf2e95ba2723940c3a711 Mon Sep 17 00:00:00 2001 From: HoldYourWaffle Date: Tue, 15 Apr 2025 16:41:59 +0200 Subject: [PATCH 2/4] chore(deps): update playwright to 1.51.1 See microsoft/playwright#30368 --- package.json | 4 +- packages/adapter-cloudflare/package.json | 2 +- packages/adapter-static/package.json | 2 +- packages/kit/package.json | 2 +- pnpm-lock.yaml | 53 ++++++++++++++---------- pnpm-workspace.yaml | 4 ++ 6 files changed, 40 insertions(+), 27 deletions(-) diff --git a/package.json b/package.json index f4a585a29940..a6439f3f2123 100644 --- a/package.json +++ b/package.json @@ -26,7 +26,7 @@ "@sveltejs/eslint-config": "^8.1.0", "@svitejs/changesets-changelog-github-compact": "^1.1.0", "eslint": "^9.6.0", - "playwright": "^1.44.1", + "playwright": "catalog:", "prettier": "^3.1.1", "prettier-plugin-svelte": "^3.1.2", "typescript-eslint": "^8.24.0" @@ -42,4 +42,4 @@ "esbuild" ] } -} \ No newline at end of file +} diff --git a/packages/adapter-cloudflare/package.json b/packages/adapter-cloudflare/package.json index 1e84904bc1c6..a9c2a821e738 100644 --- a/packages/adapter-cloudflare/package.json +++ b/packages/adapter-cloudflare/package.json @@ -45,7 +45,7 @@ "worktop": "0.8.0-next.18" }, "devDependencies": { - "@playwright/test": "^1.44.1", + "@playwright/test": "catalog:", "@sveltejs/kit": "workspace:^", "@types/node": "^18.19.48", "esbuild": "^0.24.0", diff --git a/packages/adapter-static/package.json b/packages/adapter-static/package.json index ab3e6ac81d43..857b562fc8f8 100644 --- a/packages/adapter-static/package.json +++ b/packages/adapter-static/package.json @@ -39,7 +39,7 @@ "test": "pnpm -r --workspace-concurrency 1 --filter=\"./test/**\" test" }, "devDependencies": { - "@playwright/test": "^1.44.1", + "@playwright/test": "catalog:", "@sveltejs/kit": "workspace:^", "@sveltejs/vite-plugin-svelte": "^5.0.1", "@types/node": "^18.19.48", diff --git a/packages/kit/package.json b/packages/kit/package.json index 8cfa35a03d5f..5ebbf1f39617 100644 --- a/packages/kit/package.json +++ b/packages/kit/package.json @@ -31,7 +31,7 @@ "sirv": "^3.0.0" }, "devDependencies": { - "@playwright/test": "^1.44.1", + "@playwright/test": "catalog:", "@sveltejs/vite-plugin-svelte": "^5.0.1", "@types/connect": "^3.4.38", "@types/node": "^18.19.48", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 1e8b3d6ebe9d..540cd02f1575 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -4,6 +4,15 @@ settings: autoInstallPeers: true excludeLinksFromLockfile: false +catalogs: + default: + '@playwright/test': + specifier: ^1.51.1 + version: 1.51.1 + playwright: + specifier: ^1.51.1 + version: 1.51.1 + importers: .: @@ -21,8 +30,8 @@ importers: specifier: ^9.6.0 version: 9.6.0 playwright: - specifier: ^1.44.1 - version: 1.44.1 + specifier: 'catalog:' + version: 1.51.1 prettier: specifier: ^3.1.1 version: 3.3.3 @@ -68,8 +77,8 @@ importers: version: 4.0.0(@cloudflare/workers-types@4.20250312.0) devDependencies: '@playwright/test': - specifier: ^1.44.1 - version: 1.44.1 + specifier: 'catalog:' + version: 1.51.1 '@sveltejs/kit': specifier: workspace:^ version: link:../kit @@ -214,8 +223,8 @@ importers: packages/adapter-static: devDependencies: '@playwright/test': - specifier: ^1.44.1 - version: 1.44.1 + specifier: 'catalog:' + version: 1.51.1 '@sveltejs/kit': specifier: workspace:^ version: link:../kit @@ -391,8 +400,8 @@ importers: version: 3.0.0 devDependencies: '@playwright/test': - specifier: ^1.44.1 - version: 1.44.1 + specifier: 'catalog:' + version: 1.51.1 '@sveltejs/vite-plugin-svelte': specifier: ^5.0.1 version: 5.0.1(svelte@5.23.1)(vite@6.0.11(@types/node@18.19.50)(lightningcss@1.24.1)) @@ -1694,9 +1703,9 @@ packages: resolution: {integrity: sha512-+1VkjdD0QBLPodGrJUeqarH8VAIvQODIbwh9XpP5Syisf7YoQgsJKPNFoqqLQlu+VQ/tVSshMR6loPMn8U+dPg==} engines: {node: '>=14'} - '@playwright/test@1.44.1': - resolution: {integrity: sha512-1hZ4TNvD5z9VuhNJ/walIjvMVvYkZKf71axoF/uiAqpntQJXpG64dlXhoDXE3OczPuTuvjf/M5KWFg5VAVUS3Q==} - engines: {node: '>=16'} + '@playwright/test@1.51.1': + resolution: {integrity: sha512-nM+kEaTSAoVlXmMPH10017vn3FSiFqr/bh4fKg9vmAdMfd9SDqRZNvPSiAHADc/itWak+qPvMPZQOPwCBW7k7Q==} + engines: {node: '>=18'} hasBin: true '@polka/url@1.0.0-next.28': @@ -2950,14 +2959,14 @@ packages: resolution: {integrity: sha512-uB80kBFb/tfd68bVleG9T5GGsGPjJrLAUpR5PZIrhBnIaRTQRjqdJSsIKkOP6OAIFbj7GOrcudc5pNjZ+geV2g==} engines: {node: '>=6'} - playwright-core@1.44.1: - resolution: {integrity: sha512-wh0JWtYTrhv1+OSsLPgFzGzt67Y7BE/ZS3jEqgGBlp2ppp1ZDj8c+9IARNW4dwf1poq5MgHreEM2KV/GuR4cFA==} - engines: {node: '>=16'} + playwright-core@1.51.1: + resolution: {integrity: sha512-/crRMj8+j/Nq5s8QcvegseuyeZPxpQCZb6HNk3Sos3BlZyAknRjoyJPFWkpNn8v0+P3WiwqFF8P+zQo4eqiNuw==} + engines: {node: '>=18'} hasBin: true - playwright@1.44.1: - resolution: {integrity: sha512-qr/0UJ5CFAtloI3avF95Y0L1xQo6r3LQArLIg/z/PoGJ6xa+EwzrwO5lpNr/09STxdHuUoP2mvuELJS+hLdtgg==} - engines: {node: '>=16'} + playwright@1.51.1: + resolution: {integrity: sha512-kkx+MB2KQRkyxjYPc3a0wLZZoDczmppyGJIvQ43l+aZihkaVvmu/21kiyaHeHjiFxjxNNFnUncKmcGIyOojsaw==} + engines: {node: '>=18'} hasBin: true polka@1.0.0-next.28: @@ -4044,9 +4053,9 @@ snapshots: '@pkgjs/parseargs@0.11.0': optional: true - '@playwright/test@1.44.1': + '@playwright/test@1.51.1': dependencies: - playwright: 1.44.1 + playwright: 1.51.1 '@polka/url@1.0.0-next.28': {} @@ -5263,11 +5272,11 @@ snapshots: pify@4.0.1: {} - playwright-core@1.44.1: {} + playwright-core@1.51.1: {} - playwright@1.44.1: + playwright@1.51.1: dependencies: - playwright-core: 1.44.1 + playwright-core: 1.51.1 optionalDependencies: fsevents: 2.3.2 diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml index 3ecf23a8fd4b..9e07a7399141 100644 --- a/pnpm-workspace.yaml +++ b/pnpm-workspace.yaml @@ -9,3 +9,7 @@ packages: - 'packages/create-svelte/templates/*' - '!.test-tmp/**' - 'playgrounds/*' + +catalog: + "playwright": "^1.51.1" + "@playwright/test": "^1.51.1" From 37a182d391d683a3d2dead95502577d57351d33d Mon Sep 17 00:00:00 2001 From: Tee Ming Date: Wed, 16 Apr 2025 17:28:46 +0800 Subject: [PATCH 3/4] we're using playwright to test not as a library --- package.json | 2 +- pnpm-lock.yaml | 9 +++------ pnpm-workspace.yaml | 1 - 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/package.json b/package.json index a6439f3f2123..a1234384ddc1 100644 --- a/package.json +++ b/package.json @@ -26,7 +26,7 @@ "@sveltejs/eslint-config": "^8.1.0", "@svitejs/changesets-changelog-github-compact": "^1.1.0", "eslint": "^9.6.0", - "playwright": "catalog:", + "@playwright/test": "catalog:", "prettier": "^3.1.1", "prettier-plugin-svelte": "^3.1.2", "typescript-eslint": "^8.24.0" diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 540cd02f1575..4673662455b8 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -9,9 +9,6 @@ catalogs: '@playwright/test': specifier: ^1.51.1 version: 1.51.1 - playwright: - specifier: ^1.51.1 - version: 1.51.1 importers: @@ -20,6 +17,9 @@ importers: '@changesets/cli': specifier: ^2.27.11 version: 2.27.11 + '@playwright/test': + specifier: 'catalog:' + version: 1.51.1 '@sveltejs/eslint-config': specifier: ^8.1.0 version: 8.1.0(@stylistic/eslint-plugin-js@2.1.0(eslint@9.6.0))(eslint-config-prettier@9.1.0(eslint@9.6.0))(eslint-plugin-n@17.16.1(eslint@9.6.0)(typescript@5.6.3))(eslint-plugin-svelte@2.41.0(eslint@9.6.0)(svelte@5.23.1))(eslint@9.6.0)(typescript-eslint@8.26.0(eslint@9.6.0)(typescript@5.6.3))(typescript@5.6.3) @@ -29,9 +29,6 @@ importers: eslint: specifier: ^9.6.0 version: 9.6.0 - playwright: - specifier: 'catalog:' - version: 1.51.1 prettier: specifier: ^3.1.1 version: 3.3.3 diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml index 9e07a7399141..c6f37693af59 100644 --- a/pnpm-workspace.yaml +++ b/pnpm-workspace.yaml @@ -11,5 +11,4 @@ packages: - 'playgrounds/*' catalog: - "playwright": "^1.51.1" "@playwright/test": "^1.51.1" From 1edbc303a8aa70b6d2b675ab926f8c2633657cc0 Mon Sep 17 00:00:00 2001 From: Tee Ming Date: Wed, 16 Apr 2025 18:43:41 +0800 Subject: [PATCH 4/4] some weird fix --- packages/kit/test/apps/basics/test/cross-platform/test.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/kit/test/apps/basics/test/cross-platform/test.js b/packages/kit/test/apps/basics/test/cross-platform/test.js index 9910bed94aba..2cdff4d9d844 100644 --- a/packages/kit/test/apps/basics/test/cross-platform/test.js +++ b/packages/kit/test/apps/basics/test/cross-platform/test.js @@ -34,7 +34,8 @@ test.describe('CSS', () => { test('applies styles correctly', async ({ page, get_computed_style }) => { await page.goto('/css'); - + // without this assertion, the WebKit browser seems to close before we can compute the styles + await expect(page.locator('.styled')).toBeVisible(); check_styles(get_computed_style); });