(fix) ignore script/styles inside comments (#460)

#143

Author: dummdidumm

packages/svelte2tsx/src/htmlxparser.ts

@@ -33,19 +33,23 @@ function parseAttributes(str: string, start: number) {
 }
 
 function extractTag(htmlx: string, tag: 'script' | 'style') {
-    const exp = new RegExp(`(<${tag}([\\S\\s]*?)>)([\\S\\s]*?)<\\/${tag}>`, 'g');
+    const exp = new RegExp(`(<!--[^]*?-->)|(<${tag}([\\S\\s]*?)>)([\\S\\s]*?)<\\/${tag}>`, 'g');
     const matches: Node[] = [];
 
     let match: RegExpExecArray | null = null;
     while ((match = exp.exec(htmlx)) != null) {
-        const content = match[3];
+        if (match[0].startsWith('<!--')) {
+            // Tag is inside comment
+            continue;
+        }
 
+        const content = match[4];
         if (!content) {
             // Self-closing/empty tags don't need replacement
             continue;
         }
 
-        const start = match.index + match[1].length;
+        const start = match.index + match[2].length;
         const end = start + content.length;
         const containerStart = match.index;
         const containerEnd = match.index + match[0].length;
@@ -55,7 +59,7 @@ function extractTag(htmlx: string, tag: 'script' | 'style') {
             end: containerEnd,
             name: tag,
             type: tag === 'style' ? 'Style' : 'Script',
-            attributes: parseAttributes(match[2], containerStart + `<${tag}`.length),
+            attributes: parseAttributes(match[3], containerStart + `<${tag}`.length),
             content: {
                 type: 'Text',
                 start,

packages/svelte2tsx/test/svelte2tsx/samples/commented-out-script/expected.tsx

@@ -0,0 +1,12 @@
+///<reference types="svelte" />
+<></>;function render() {
+
+  // } // <- error here
+;
+() => (<>
+
+</>);
+return { props: {}, slots: {}, getters: {}, events: {} }}
+
+export default class Input__SvelteComponent_ extends createSvelte2TsxComponent(__sveltets_partial(render)) {
+}

packages/svelte2tsx/test/svelte2tsx/samples/commented-out-script/input.svelte

@@ -0,0 +1,6 @@
+<script>
+  // } // <- error here
+</script>
+
+<!-- <script src="/lib/jodit.es2018.min.js">
+</script> -->