chore: remove some unused code (#9593)

Rich-Harris · web-flow · commit 1f4ae5ef451f · 2023-11-22T20:10:12.000+01:00
Co-authored-by: Rich Harris &lt;rich.harris@vercel.com&gt;
diff --git a/.changeset/two-falcons-buy.md b/.changeset/two-falcons-buy.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+chore: remove unused code
diff --git a/packages/svelte/src/compiler/phases/1-parse/acorn.js b/packages/svelte/src/compiler/phases/1-parse/acorn.js
@@ -58,7 +58,6 @@ export function get_comment_handlers(source) {
 	 * @typedef {import('estree').Comment & {
 	 *   start: number;
 	 *   end: number;
-	 *   has_trailing_newline?: boolean
 	 * }} CommentWithLocation
 	 */
 
@@ -91,35 +90,26 @@ export function get_comment_handlers(source) {
 		add_comments(ast) {
 			if (comments.length === 0) return;
 
-			walk(
-				ast,
-				{},
-				{
-					_(node, { next }) {
-						let comment;
+			walk(ast, null, {
+				_(node, { next }) {
+					let comment;
 
-						while (comments[0] && comments[0].start < node.start) {
-							comment = /** @type {CommentWithLocation} */ (comments.shift());
-
-							const next = comments[0] || node;
-							comment.has_trailing_newline =
-								comment.type === 'Line' || /\n/.test(source.slice(comment.end, next.start));
-
-							(node.leadingComments ||= []).push(comment);
-						}
+					while (comments[0] && comments[0].start < node.start) {
+						comment = /** @type {CommentWithLocation} */ (comments.shift());
+						(node.leadingComments ||= []).push(comment);
+					}
 
-						next();
+					next();
 
-						if (comments[0]) {
-							const slice = source.slice(node.end, comments[0].start);
+					if (comments[0]) {
+						const slice = source.slice(node.end, comments[0].start);
 
-							if (/^[,) \t]*$/.test(slice)) {
-								node.trailingComments = [/** @type {CommentWithLocation} */ (comments.shift())];
-							}
+						if (/^[,) \t]*$/.test(slice)) {
+							node.trailingComments = [/** @type {CommentWithLocation} */ (comments.shift())];
 						}
 					}
 				}
-			);
+			});
 		}
 	};
 }
diff --git a/packages/svelte/src/compiler/phases/3-transform/client/visitors/template.js b/packages/svelte/src/compiler/phases/3-transform/client/visitors/template.js
@@ -1087,9 +1087,7 @@ function create_block(parent, name, nodes, context) {
 		/** @type {import('estree').Statement} */ (update).leadingComments = [
 			{
 				type: 'Block',
-				value: ` Update `,
-				// @ts-expect-error
-				has_trailing_newline: true
+				value: ` Update `
 			}
 		];
 	}
@@ -1107,9 +1105,7 @@ function create_block(parent, name, nodes, context) {
 		body[0].leadingComments = [
 			{
 				type: 'Block',
-				value: ` Init `,
-				// @ts-expect-error
-				has_trailing_newline: true
+				value: ` Init `
 			}
 		];
 	}
diff --git a/packages/svelte/src/compiler/phases/3-transform/index.js b/packages/svelte/src/compiler/phases/3-transform/index.js
@@ -32,15 +32,11 @@ export function transform_component(analysis, source, options) {
 		program.body[0].leadingComments = [
 			{
 				type: 'Line',
-				value: ` ${basename} (Svelte v${VERSION})`,
-				// @ts-ignore
-				has_trailing_newline: true
+				value: ` ${basename} (Svelte v${VERSION})`
 			},
 			{
 				type: 'Line',
-				value: ' Note: compiler output will change before 5.0 is released!',
-				// @ts-ignore
-				has_trailing_newline: true
+				value: ' Note: compiler output will change before 5.0 is released!'
 			}
 		];
 	}
@@ -86,9 +82,7 @@ export function transform_module(analysis, source, options) {
 		program.body[0].leadingComments = [
 			{
 				type: 'Block',
-				value: ` ${basename} generated by Svelte v${VERSION} `,
-				// @ts-ignore
-				has_trailing_newline: true
+				value: ` ${basename} generated by Svelte v${VERSION} `
 			}
 		];
 	}
diff --git a/packages/svelte/tests/parser-legacy/samples/javascript-comments/output.json b/packages/svelte/tests/parser-legacy/samples/javascript-comments/output.json
@@ -109,8 +109,7 @@
 												"type": "Block",
 												"value": " another comment ",
 												"start": 163,
-												"end": 184,
-												"has_trailing_newline": true
+												"end": 184
 											}
 										]
 									}
@@ -121,8 +120,7 @@
 									"type": "Line",
 									"value": " comment",
 									"start": 141,
-									"end": 151,
-									"has_trailing_newline": true
+									"end": 151
 								}
 							]
 						}
@@ -222,8 +220,7 @@
 							"type": "Line",
 							"value": " a leading comment",
 							"start": 10,
-							"end": 30,
-							"has_trailing_newline": true
+							"end": 30
 						}
 					],
 					"trailingComments": [
@@ -290,8 +287,7 @@
 							"type": "Block",
 							"value": "* a comment ",
 							"start": 72,
-							"end": 88,
-							"has_trailing_newline": true
+							"end": 88
 						}
 					]
 				}

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'svelte': patch
 +---
++
 +chore: remove unused code
Original file line number	Diff line number	Diff line change
`@@ -1087,9 +1087,7 @@ function create_block(parent, name, nodes, context) {`
`1087`	`1087`	`/** @type {import('estree').Statement} */ (update).leadingComments = [`
`1088`	`1088`	`{`
`1089`	`1089`	`type: 'Block',`
`1090`		- value: ` Update `,
`1091`		`- // @ts-expect-error`
`1092`		`- has_trailing_newline: true`
	`1090`	+ value: ` Update `
`1093`	`1091`	`}`
`1094`	`1092`	`];`
`1095`	`1093`	`}`
`@@ -1107,9 +1105,7 @@ function create_block(parent, name, nodes, context) {`
`1107`	`1105`	`body[0].leadingComments = [`
`1108`	`1106`	`{`
`1109`	`1107`	`type: 'Block',`
`1110`		- value: ` Init `,
`1111`		`- // @ts-expect-error`
`1112`		`- has_trailing_newline: true`
	`1108`	+ value: ` Init `
`1113`	`1109`	`}`
`1114`	`1110`	`];`
`1115`	`1111`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,15 +32,11 @@ export function transform_component(analysis, source, options) {`
`32`	`32`	`program.body[0].leadingComments = [`
`33`	`33`	`{`
`34`	`34`	`type: 'Line',`
`35`		- value: ` ${basename} (Svelte v${VERSION})`,
`36`		`- // @ts-ignore`
`37`		`- has_trailing_newline: true`
	`35`	+ value: ` ${basename} (Svelte v${VERSION})`
`38`	`36`	`},`
`39`	`37`	`{`
`40`	`38`	`type: 'Line',`
`41`		`- value: ' Note: compiler output will change before 5.0 is released!',`
`42`		`- // @ts-ignore`
`43`		`- has_trailing_newline: true`
	`39`	`+ value: ' Note: compiler output will change before 5.0 is released!'`
`44`	`40`	`}`
`45`	`41`	`];`
`46`	`42`	`}`
`@@ -86,9 +82,7 @@ export function transform_module(analysis, source, options) {`
`86`	`82`	`program.body[0].leadingComments = [`
`87`	`83`	`{`
`88`	`84`	`type: 'Block',`
`89`		- value: ` ${basename} generated by Svelte v${VERSION} `,
`90`		`- // @ts-ignore`
`91`		`- has_trailing_newline: true`
	`85`	+ value: ` ${basename} generated by Svelte v${VERSION} `
`92`	`86`	`}`
`93`	`87`	`];`
`94`	`88`	`}`
Original file line number	Diff line number	Diff line change
`@@ -109,8 +109,7 @@`
`109`	`109`	`"type": "Block",`
`110`	`110`	`"value": " another comment ",`
`111`	`111`	`"start": 163,`
`112`		`- "end": 184,`
`113`		`- "has_trailing_newline": true`
	`112`	`+ "end": 184`
`114`	`113`	`}`
`115`	`114`	`]`
`116`	`115`	`}`
`@@ -121,8 +120,7 @@`
`121`	`120`	`"type": "Line",`
`122`	`121`	`"value": " comment",`
`123`	`122`	`"start": 141,`
`124`		`- "end": 151,`
`125`		`- "has_trailing_newline": true`
	`123`	`+ "end": 151`
`126`	`124`	`}`
`127`	`125`	`]`
`128`	`126`	`}`
`@@ -222,8 +220,7 @@`
`222`	`220`	`"type": "Line",`
`223`	`221`	`"value": " a leading comment",`
`224`	`222`	`"start": 10,`
`225`		`- "end": 30,`
`226`		`- "has_trailing_newline": true`
	`223`	`+ "end": 30`
`227`	`224`	`}`
`228`	`225`	`],`
`229`	`226`	`"trailingComments": [`
`@@ -290,8 +287,7 @@`
`290`	`287`	`"type": "Block",`
`291`	`288`	`"value": "* a comment ",`
`292`	`289`	`"start": 72,`
`293`		`- "end": 88,`
`294`		`- "has_trailing_newline": true`
	`290`	`+ "end": 88`
`295`	`291`	`}`
`296`	`292`	`]`
`297`	`293`	`}`