Skip to content

Commit a159998

Browse files
committed
Merge pull request #2115 from delenius/enums
Use objects for enums, not constructor functions
2 parents 5b0d8b1 + 86154f8 commit a159998

File tree

5 files changed

+19
-29
lines changed

5 files changed

+19
-29
lines changed

modules/swagger-codegen/src/main/resources/Javascript/enumClass.mustache

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,12 @@ if ( typeof define === "function" && define.amd ) {
66
});
77
}
88

9-
var {{datatypeWithEnum}} = function {{datatypeWithEnum}}() {
10-
var self = this;
11-
9+
var {{datatypeWithEnum}} = {
1210
{{#allowableValues}}{{#enumVars}}
1311
/**
1412
* @const
1513
*/
16-
self.{{name}} = "{{value}}"{{^-last}},
17-
{{/-last}}{{#-last}};{{/-last}}{{/enumVars}}{{/allowableValues}}
14+
{{name}}: "{{value}}"{{^-last}},
15+
{{/-last}}{{/enumVars}}{{/allowableValues}}
1816

1917
}

samples/client/petstore/javascript-promise/src/model/Order.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,24 +24,22 @@ if ( typeof define === "function" && define.amd ) {
2424
});
2525
}
2626

27-
var StatusEnum = function StatusEnum() {
28-
var self = this;
29-
27+
var StatusEnum = {
3028

3129
/**
3230
* @const
3331
*/
34-
self.PLACED = "placed",
32+
PLACED: "placed",
3533

3634
/**
3735
* @const
3836
*/
39-
self.APPROVED = "approved",
37+
APPROVED: "approved",
4038

4139
/**
4240
* @const
4341
*/
44-
self.DELIVERED = "delivered";
42+
DELIVERED: "delivered"
4543

4644
}
4745

samples/client/petstore/javascript-promise/src/model/Pet.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,24 +24,22 @@ if ( typeof define === "function" && define.amd ) {
2424
});
2525
}
2626

27-
var StatusEnum = function StatusEnum() {
28-
var self = this;
29-
27+
var StatusEnum = {
3028

3129
/**
3230
* @const
3331
*/
34-
self.AVAILABLE = "available",
32+
AVAILABLE: "available",
3533

3634
/**
3735
* @const
3836
*/
39-
self.PENDING = "pending",
37+
PENDING: "pending",
4038

4139
/**
4240
* @const
4341
*/
44-
self.SOLD = "sold";
42+
SOLD: "sold"
4543

4644
}
4745

samples/client/petstore/javascript/src/model/Order.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,24 +24,22 @@ if ( typeof define === "function" && define.amd ) {
2424
});
2525
}
2626

27-
var StatusEnum = function StatusEnum() {
28-
var self = this;
29-
27+
var StatusEnum = {
3028

3129
/**
3230
* @const
3331
*/
34-
self.PLACED = "placed",
32+
PLACED: "placed",
3533

3634
/**
3735
* @const
3836
*/
39-
self.APPROVED = "approved",
37+
APPROVED: "approved",
4038

4139
/**
4240
* @const
4341
*/
44-
self.DELIVERED = "delivered";
42+
DELIVERED: "delivered"
4543

4644
}
4745

samples/client/petstore/javascript/src/model/Pet.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,24 +24,22 @@ if ( typeof define === "function" && define.amd ) {
2424
});
2525
}
2626

27-
var StatusEnum = function StatusEnum() {
28-
var self = this;
29-
27+
var StatusEnum = {
3028

3129
/**
3230
* @const
3331
*/
34-
self.AVAILABLE = "available",
32+
AVAILABLE: "available",
3533

3634
/**
3735
* @const
3836
*/
39-
self.PENDING = "pending",
37+
PENDING: "pending",
4038

4139
/**
4240
* @const
4341
*/
44-
self.SOLD = "sold";
42+
SOLD: "sold"
4543

4644
}
4745

0 commit comments

Comments
 (0)