Merge pull request #850 from ahoppen/data-leak

ahoppen · web-flow · commit 0d6718284b65 · 2024-10-30T14:11:55.000-07:00
Fix a memory leak in `DispatchData.withUnsafeBytes`
diff --git a/src/swift/Data.swift b/src/swift/Data.swift
@@ -110,7 +110,7 @@ public struct DispatchData : RandomAccessCollection {
 	{
 		var ptr: UnsafeRawPointer? = nil
 		var size = 0
-		let data = CDispatch.dispatch_data_create_map(__wrapped.__wrapped, &ptr, &size)
+		let data = DispatchData(data: CDispatch.dispatch_data_create_map(__wrapped.__wrapped, &ptr, &size))
 		let contentPtr = ptr!.bindMemory(
 			to: ContentType.self, capacity: size / MemoryLayout<ContentType>.stride)
 		defer { _fixLifetime(data) }

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ public struct DispatchData : RandomAccessCollection {`
`110`	`110`	`{`
`111`	`111`	`var ptr: UnsafeRawPointer? = nil`
`112`	`112`	`var size = 0`
`113`		`- let data = CDispatch.dispatch_data_create_map(__wrapped.__wrapped, &ptr, &size)`
	`113`	`+ let data = DispatchData(data: CDispatch.dispatch_data_create_map(__wrapped.__wrapped, &ptr, &size))`
`114`	`114`	`let contentPtr = ptr!.bindMemory(`
`115`	`115`	`to: ContentType.self, capacity: size / MemoryLayout<ContentType>.stride)`
`116`	`116`	`defer { _fixLifetime(data) }`