Skip to content

Commit a22a5bb

Browse files
committed
WiX: remove unnecessary MSI Property
The ability to distribute the debug information with the installer has been removed as the total size of the debug information vastly outsizes the packaging of the toolchain (~7x). The traditional way to distribute debug information on Windows is via a symbol server with indexing via SaaS such as Azure Packages. Remove the now defunct property setting.
1 parent 9e565c2 commit a22a5bb

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

platforms/Windows/installer-amd64.wxs

+2-6
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,13 @@
77
<Chain>
88
<?if $(var.RequiredChain) != "" ?>
99
<?foreach MSI in $(var.RequiredChain) ?>
10-
<MsiPackage SourceFile="$(var.MSI_LOCATION)\$(var.MSI)" Compressed="yes">
11-
<MsiProperty Name="INSTALL_DEBUGINFO" Value="[INSTALL_DEBUGINFO]" />
12-
</MsiPackage>
10+
<MsiPackage SourceFile="$(var.MSI_LOCATION)\$(var.MSI)" Compressed="yes" />
1311
<?endforeach?>
1412
<?endif?>
1513

1614
<?if $(var.OptionalChain) != "" ?>
1715
<?foreach MSI in $(var.OptionalChain) ?>
18-
<MsiPackage SourceFile="$(var.MSI_LOCATION)\$(var.MSI)" Compressed="yes" Visible="yes">
19-
<MsiProperty Name="INSTALL_DEBUGINFO" Value="[INSTALL_DEBUGINFO]" />
20-
</MsiPackage>
16+
<MsiPackage SourceFile="$(var.MSI_LOCATION)\$(var.MSI)" Compressed="yes" Visible="yes" />
2117
<?endforeach?>
2218
<?endif?>
2319
</Chain>

platforms/Windows/installer-arm64.wxs

+2-6
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,13 @@
77
<Chain>
88
<?if $(var.RequiredChain) != "" ?>
99
<?foreach MSI in $(var.RequiredChain) ?>
10-
<MsiPackage SourceFile="$(var.MSI_LOCATION)\$(var.MSI)" Compressed="yes">
11-
<MsiProperty Name="INSTALL_DEBUGINFO" Value="[INSTALL_DEBUGINFO]" />
12-
</MsiPackage>
10+
<MsiPackage SourceFile="$(var.MSI_LOCATION)\$(var.MSI)" Compressed="yes" />
1311
<?endforeach?>
1412
<?endif?>
1513

1614
<?if $(var.OptionalChain) != "" ?>
1715
<?foreach MSI in $(var.OptionalChain) ?>
18-
<MsiPackage SourceFile="$(var.MSI_LOCATION)\$(var.MSI)" Compressed="yes" Visible="yes">
19-
<MsiProperty Name="INSTALL_DEBUGINFO" Value="[INSTALL_DEBUGINFO]" />
20-
</MsiPackage>
16+
<MsiPackage SourceFile="$(var.MSI_LOCATION)\$(var.MSI)" Compressed="yes" Visible="yes" />
2117
<?endforeach?>
2218
<?endif?>
2319
</Chain>

0 commit comments

Comments
 (0)