Merge pull request #79957 from eeckstein/revert-assert

kperryua · web-flow · commit 9b876fd7796d · 2025-03-12T11:56:45.000-07:00
Revert "IRGen: convert two `assert`s to `ASSERT` to check the conditions also in a release-built compiler"
diff --git a/include/swift/IRGen/Linking.h b/include/swift/IRGen/Linking.h
@@ -1123,7 +1123,7 @@ class LinkEntity {
 
   static LinkEntity forProtocolWitnessTable(const ProtocolConformance *C) {
     if (isEmbedded(C)) {
-      ASSERT(C->getProtocol()->requiresClass());
+      assert(C->getProtocol()->requiresClass());
     }
 
     LinkEntity entity;
diff --git a/lib/IRGen/GenProto.cpp b/lib/IRGen/GenProto.cpp
@@ -3752,7 +3752,7 @@ llvm::Value *irgen::emitWitnessTableRef(IRGenFunction &IGF,
 
   // In Embedded Swift, only class-bound wtables are allowed.
   if (srcType->getASTContext().LangOpts.hasFeature(Feature::Embedded)) {
-    ASSERT(proto->requiresClass());
+    assert(proto->requiresClass());
   }
 
   assert(Lowering::TypeConverter::protocolRequiresWitnessTable(proto)

Original file line number	Diff line number	Diff line change
`@@ -1123,7 +1123,7 @@ class LinkEntity {`
`1123`	`1123`
`1124`	`1124`	`static LinkEntity forProtocolWitnessTable(const ProtocolConformance *C) {`
`1125`	`1125`	`if (isEmbedded(C)) {`
`1126`		`- ASSERT(C->getProtocol()->requiresClass());`
	`1126`	`+ assert(C->getProtocol()->requiresClass());`
`1127`	`1127`	`}`
`1128`	`1128`
`1129`	`1129`	`LinkEntity entity;`
Original file line number	Diff line number	Diff line change
`@@ -3752,7 +3752,7 @@ llvm::Value *irgen::emitWitnessTableRef(IRGenFunction &IGF,`
`3752`	`3752`
`3753`	`3753`	`// In Embedded Swift, only class-bound wtables are allowed.`
`3754`	`3754`	`if (srcType->getASTContext().LangOpts.hasFeature(Feature::Embedded)) {`
`3755`		`- ASSERT(proto->requiresClass());`
	`3755`	`+ assert(proto->requiresClass());`
`3756`	`3756`	`}`
`3757`	`3757`
`3758`	`3758`	`assert(Lowering::TypeConverter::protocolRequiresWitnessTable(proto)`