Skip to content

Commit c8b1dc7

Browse files
test: Disable executable lit tests with WASI threads for now
We should enable them once WasmKit supports WASI threads.
1 parent ca5e7a6 commit c8b1dc7

File tree

1 file changed

+8
-1
lines changed
  • utils/swift_build_support/swift_build_support/products

1 file changed

+8
-1
lines changed

utils/swift_build_support/swift_build_support/products/wasmstdlib.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ def test(self, host_target):
133133
wasmkit_build_path = os.path.join(
134134
build_root, '%s-%s' % ('wasmkit', host_target))
135135
wasmkit_bin_path = wasmkit.WasmKit.cli_file_path(wasmkit_build_path)
136-
if not os.path.exists(wasmkit_bin_path):
136+
if not os.path.exists(wasmkit_bin_path) or not self.should_test_executable():
137137
test_target = "check-swift-only_non_executable-wasi-wasm32-custom"
138138
else:
139139
test_target = "check-swift-wasi-wasm32-custom"
@@ -147,6 +147,9 @@ def test(self, host_target):
147147
}
148148
self.test_with_cmake(None, [test_target], self._build_variant, [], test_env=env)
149149

150+
def should_test_executable(self):
151+
return True
152+
150153
@property
151154
def _build_variant(self):
152155
return self.args.build_variant
@@ -177,6 +180,10 @@ def get_dependencies(cls):
177180

178181

179182
class WasmThreadsStdlib(WasmStdlib):
183+
def should_test_executable(self):
184+
# TODO(katei): Enable tests once WasmKit supports WASI threads
185+
return False
186+
180187
def add_extra_cmake_options(self):
181188
self.cmake_options.define('SWIFT_THREADING_PACKAGE:STRING', 'pthreads')
182189
self.cmake_options.define('SWIFT_STDLIB_EXTRA_C_COMPILE_FLAGS:STRING',

0 commit comments

Comments
 (0)