Skip to content

Commit d733338

Browse files
authored
build-script: fix --skip-build-llvm not having full effect (#82233)
While LLVM cannot be completely disabled when Swift or LLDB are built, we should still allow skipping LLVM configuration and build steps when Swift and LLDB are not built. This can happen, for example, when `build-script` user wants an ad-hoc incremental build with `--skip-build-swift` and `--skip-build-lldb` for products that don't depend on LLVM and Swift, or if LLVM and Swift were already configured and built in previous `build-script` invocations.
1 parent bf6694d commit d733338

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

utils/swift_build_support/swift_build_support/build_script_invocation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,7 @@ def compute_product_pipelines(self):
623623
# Swift still needs a few LLVM targets like tblgen to be built for it to be
624624
# configured. Instead, handle this in the product for now.
625625
builder.add_product(products.LLVM,
626-
is_enabled=True)
626+
is_enabled=self.args.build_llvm or self.args.build_swift or self.args.build_lldb)
627627

628628
builder.add_product(products.StaticSwiftLinuxConfig,
629629
is_enabled=self.args.install_static_linux_config)

0 commit comments

Comments
 (0)