Merge pull request #76623 from swiftlang/revert-76595-wip-release-dist-execute-return

Revert "[Distributed] remote calls over-retain returned values"

Author: shahmishal

stdlib/public/Distributed/DistributedActorSystem.swift

@@ -531,8 +531,8 @@ extension DistributedActorSystem {
     }
 
     // Decode the return type
-    func allocateReturnTypeBuffer<R>(_: R.Type) -> UnsafeMutableRawPointer? {
-      return UnsafeMutableRawPointer(UnsafeMutablePointer<R>.allocate(capacity: 1))
+    func allocateReturnTypeBuffer<R>(_: R.Type) -> UnsafeRawPointer? {
+      return UnsafeRawPointer(UnsafeMutablePointer<R>.allocate(capacity: 1))
     }
 
     let maybeReturnTypeFromTypeInfo =
@@ -555,14 +555,12 @@ extension DistributedActorSystem {
         errorCode: .typeDeserializationFailure)
     }
 
-    func doDestroyReturnTypeBuffer<R>(_: R.Type) {
-      let buf = resultBuffer.assumingMemoryBound(to: R.self)
-      buf.deinitialize(count: 1)
-      buf.deallocate()
+    func destroyReturnTypeBuffer<R>(_: R.Type) {
+      resultBuffer.assumingMemoryBound(to: R.self).deallocate()
     }
 
     defer {
-      _openExistential(returnTypeFromTypeInfo, do: doDestroyReturnTypeBuffer)
+      _openExistential(returnTypeFromTypeInfo, do: destroyReturnTypeBuffer)
     }
 
     do {

test/Distributed/Inputs/FakeDistributedActorSystems.swift

@@ -324,8 +324,6 @@ public final class FakeRoundtripActorSystem: DistributedActorSystem, @unchecked
         handler: resultHandler
       )
 
-      defer { remoteCallResult = nil }
-      defer { remoteCallError = nil }
       switch (remoteCallResult, remoteCallError) {
       case (.some(let value), nil):
         print("  << remoteCall return: \(value)")