Skip to content

Commit f87a2bf

Browse files
committed
[NFC] Presets: Small cleanup
* Remove some options that are implied by a base preset. * Remove unused preset for building with Xcode.
1 parent 140caf6 commit f87a2bf

File tree

1 file changed

+5
-41
lines changed

1 file changed

+5
-41
lines changed

utils/build-presets.ini

Lines changed: 5 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -326,14 +326,19 @@ test
326326
validation-test
327327
lit-args=-v --time-tests
328328

329+
# Set the vendor to apple
329330
compiler-vendor=apple
330331

331332
# On buildbots, always force a reconfiguration to make sure we pick up changes
332333
# in the build-script and build-presets.ini.
333334
reconfigure
334335

336+
# We want to always perform a verbose build
335337
verbose-build
338+
339+
# Build ninja while we are at it
336340
build-ninja
341+
337342
skip-test-cmark
338343

339344
[preset: buildbot_incremental_base_all_platforms]
@@ -399,28 +404,6 @@ install-libcxx
399404
[preset: buildbot_incremental,tools=RA,stdlib=RA,apple_silicon]
400405
mixin-preset=buildbot_incremental,tools=RA,stdlib=RA
401406

402-
[preset: buildbot_incremental,tools=RA,stdlib=RA,xcode]
403-
mixin-preset=buildbot_incremental,tools=RA,stdlib=RA
404-
build-subdir=buildbot_incremental_xcode
405-
406-
xcode
407-
# We do not support building cross compiled stdlibs on OS X with Xcode. So only
408-
# build the OS X SDK.
409-
skip-build-ios
410-
skip-test-ios
411-
skip-build-tvos
412-
skip-test-tvos
413-
skip-build-watchos
414-
skip-test-watchos
415-
stdlib-deployment-targets=macosx-x86_64
416-
swift-primary-variant-sdk=OSX
417-
swift-primary-variant-arch=x86_64
418-
skip-build-llbuild
419-
skip-test-llbuild
420-
skip-test-swiftpm
421-
skip-test-swift-driver
422-
skip-test-playgroundsupport
423-
424407
# This preset is used by CI to test swift-corelibs-xctest.
425408
[preset: buildbot_incremental,tools=RA,stdlib=RA,XCTest]
426409
# We don't use buildbot_incremental_base_all_platforms because we don't need to
@@ -437,7 +420,6 @@ build-swift-stdlib-unittest-extra
437420
# This preset is meant to test XCTest, not Swift or Foundation. We don't
438421
# want stochastic failures in those test suites to prevent XCTest tests from
439422
# being run.
440-
skip-test-cmark
441423
skip-test-swift
442424
skip-test-libdispatch
443425
skip-test-foundation
@@ -560,7 +542,6 @@ skip-test-swift
560542
skip-test-swiftpm
561543
skip-test-swift-driver
562544
skip-test-llbuild
563-
skip-test-cmark
564545
skip-test-playgroundsupport
565546
skip-test-swiftsyntax
566547
skip-test-skstresstester
@@ -609,24 +590,8 @@ build-subdir=buildbot_incremental
609590
release
610591
assertions
611592

612-
# We run the OS X tests and validation tests.
613-
test
614-
validation-test
615-
616593
llvm-targets-to-build=X86;ARM;AArch64;PowerPC
617594

618-
# Set the vendor to apple
619-
compiler-vendor=apple
620-
621-
# Always reconfigure cmake
622-
reconfigure
623-
624-
# We want to always perform a verbose build
625-
verbose-build
626-
627-
# Build ninja while we are at it
628-
build-ninja
629-
630595
libcxx
631596
llbuild
632597
swiftpm
@@ -1744,7 +1709,6 @@ install-swiftsyntax
17441709
install-libcxx
17451710

17461711
skip-test-swift
1747-
skip-test-cmark
17481712

17491713
[preset: mixin_swiftpm_macos_platform]
17501714
mixin-preset=

0 commit comments

Comments
 (0)