Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fails on filenames longer than rename box #2535

Closed
3 tasks done
stylerw opened this issue Mar 26, 2025 · 2 comments
Closed
3 tasks done

Rename fails on filenames longer than rename box #2535

stylerw opened this issue Mar 26, 2025 · 2 comments
Labels
bug Something isn't working waiting on op Waiting for more information from the original poster

Comments

@stylerw
Copy link

stylerw commented Mar 26, 2025

What system are you running Yazi on?

Linux X11

What terminal are you running Yazi in?

kitty 0.40.0

yazi --debug output

yazi --debug
Yazi
    Version: 25.3.7 (ad09fb8 2025-03-26)
    Debug  : false
    Triple : x86_64-unknown-linux-gnu (linux-x86_64)
    Rustc  : 1.85.1 (4eb16125 2025-03-15)
Ya
    Version: 25.3.7 (ad09fb8 2025-03-26)
Emulator
    TERM                : Some("xterm-kitty")
    TERM_PROGRAM        : None
    TERM_PROGRAM_VERSION: None
    Brand.from_env      : Some(Kitty)
    Emulator.detect     : Emulator { kind: Left(Kitty), light: false, cell_size: Some((18, 38)) }
Adapter
    Adapter.matches    : Kgp
    Dimension.available: WindowSize { rows: 18, columns: 121, width: 2178, height: 684 }
Desktop
    XDG_SESSION_TYPE           : Some("wayland")
    WAYLAND_DISPLAY            : Some("wayland-0")
    DISPLAY                    : Some(":0")
    SWAYSOCK                   : None
    HYPRLAND_INSTANCE_SIGNATURE: None
    WAYFIRE_SOCKET             : None
SSH
    shared.in_ssh_connection: false
WSL
    WSL: false
Variables
    SHELL           : Some("/bin/zsh")
    EDITOR          : Some("nvim")
    VISUAL          : Some("nvim")
    YAZI_FILE_ONE   : None
    YAZI_CONFIG_HOME: None
    YAZI_ZOXIDE_OPTS: None
    FZF_DEFAULT_OPTS: None
Text Opener
    default     : Some(OpenerRule { run: "nvim \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread:true })
    block-create: Some(OpenerRule { run: "nvim \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread:true })
    block-rename: Some(OpenerRule { run: "nvim \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread:true })
Multiplexers
    TMUX               : false
    tmux version       : tmux 3.5a
    tmux build flags   : enable-sixel=Unknown
    ZELLIJ_SESSION_NAME: None
    Zellij version     : No such file or directory (os error 2)
Dependencies
    file          : 5.45
    ueberzugpp    : No such file or directory (os error 2)
    ffmpeg/ffprobe: 7.1.1 / 7.1.1
    pdftoppm      : 24.08.0
    magick        : 7.1.1-45
    fzf           : 0.60.3
    fd/fdfind     : No such file or directory (os error 2) / No such file or directory (os error 2)
    rg            : 14.1.1
    chafa         : No such file or directory (os error 2)
    zoxide        : 0.9.4
    7zz/7z        : No such file or directory (os error 2) / 16.02
    jq            : 1.7.1
Clipboard
    wl-copy/paste: 2.2.1 / 2.2.1
    xclip        : No such file or directory (os error 2)
    xsel         : 1.2.1
See https://yazi-rs.github.io/docs/plugins/overview#debugging on how to enable logging or debug runtime errors.

Describe the bug

Rename fails when the filename is longer than the box for the rename option, instead removing only the amount of text which fits in the rename box and replacing it with the contents of the rename box. See example.

Minimal reproducer

Replication Steps

Create a file named, e.g.

McPrairieDog_Herbie_Student_Evaluation_of_Teaching_(SET)_-_DIRT_112_-_Formation_and_maintenance_of_burrows_[A00]_(McPrairieDog_Herbie_n)_-_WI25.pdf

Now, open the containing folder in Yazi and trigger rename using r:

This pops up a rename dialog, which starts at 'urrows', but does not allow further scrollback. Now, using that dialog, delete everything and enter:

intro_to_burrows_w25.pdf

Expected Behavior

The file is now named intro_to_burrows_w25.pdf

Observed Behavior

The file is now named:
McPrairieDog_Herbie_Student_Evaluation_of_Teaching_(SET)_-_DIRT_112_-_Formation_and_maintenance_of_intro_to_burrows_w25.pdf

Anything else?

No response

Checklist

  • I tried the latest nightly build, and the issue is still reproducible
  • I updated the debug information (yazi --debug) input box to the nightly that I tried
  • I can reproduce it after disabling all custom configs/plugins (mv ~/.config/yazi ~/.config/yazi-backup)
@stylerw stylerw added the bug Something isn't working label Mar 26, 2025
@sxyazi
Copy link
Owner

sxyazi commented Mar 26, 2025

but does not allow further scrollback

Sounds like a duplicate of #1192 and #2169.

When you reach the beginning of the input, you can still use the arrow keys to move forward and backward, but there is currently no indicator for "content remaining" yet.

@sxyazi sxyazi added the waiting on op Waiting for more information from the original poster label Mar 27, 2025
Copy link

github-actions bot commented Apr 3, 2025

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

@github-actions github-actions bot closed this as completed Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting on op Waiting for more information from the original poster
Projects
None yet
Development

No branches or pull requests

2 participants