Merge pull request #330 from rikardn/posdef

Add Rationals, is_positive_definite and is_negative_definite

Author: rikardn

symengine/__init__.py

@@ -40,6 +40,7 @@
 UniversalSet = wrapper.S.UniversalSet
 Reals = wrapper.S.Reals
 Integers = wrapper.S.Integers
+Rationals = wrapper.S.Rationals
 
 
 if have_mpfr:

symengine/lib/symengine.pxd

@@ -302,6 +302,7 @@ cdef extern from "<symengine/basic.h>" namespace "SymEngine":
     bool is_a_Interval "SymEngine::is_a<SymEngine::Interval>"(const Basic &b) nogil
     bool is_a_EmptySet "SymEngine::is_a<SymEngine::EmptySet>"(const Basic &b) nogil
     bool is_a_Reals "SymEngine::is_a<SymEngine::Reals>"(const Basic &b) nogil
+    bool is_a_Rationals "SymEngine::is_a<SymEngine::Rationals>"(const Basic &b) nogil
     bool is_a_Integers "SymEngine::is_a<SymEngine::Integers>"(const Basic &b) nogil
     bool is_a_UniversalSet "SymEngine::is_a<SymEngine::UniversalSet>"(const Basic &b) nogil
     bool is_a_FiniteSet "SymEngine::is_a<SymEngine::FiniteSet>"(const Basic &b) nogil
@@ -827,6 +828,8 @@ cdef extern from "<symengine/matrix.h>" namespace "SymEngine":
         int is_hermitian() nogil
         int is_weakly_diagonally_dominant() nogil
         int is_strictly_diagonally_dominant() nogil
+        int is_positive_definite() nogil
+        int is_negative_definite() nogil
 
     bool is_a_DenseMatrix "SymEngine::is_a<SymEngine::DenseMatrix>"(const MatrixBase &b) nogil
     DenseMatrix* static_cast_DenseMatrix "static_cast<SymEngine::DenseMatrix*>"(const MatrixBase *a)
@@ -1057,6 +1060,8 @@ cdef extern from "<symengine/sets.h>" namespace "SymEngine":
         pass
     cdef cppclass Reals(Set):
         pass
+    cdef cppclass Rationals(Set):
+        pass
     cdef cppclass Integers(Set):
         pass
     cdef cppclass UniversalSet(Set):
@@ -1075,6 +1080,7 @@ cdef extern from "<symengine/sets.h>" namespace "SymEngine":
     cdef rcp_const_basic interval(RCP[const Number] &start, RCP[const Number] &end, bool l, bool r) nogil except +
     cdef RCP[const EmptySet] emptyset() nogil except +
     cdef RCP[const Reals] reals() nogil except +
+    cdef RCP[const Rationals] rationals() nogil except +
     cdef RCP[const Integers] integers() nogil except +
     cdef RCP[const UniversalSet] universalset() nogil except +
     cdef RCP[const Set] finiteset(set_basic &container) nogil except +

symengine/lib/symengine_wrapper.pyx

@@ -235,6 +235,8 @@ cdef object c2py(rcp_const_basic o):
         r = Set.__new__(Reals)
     elif (symengine.is_a_Integers(deref(o))):
         r = Set.__new__(Integers)
+    elif (symengine.is_a_Rationals(deref(o))):
+        r = Set.__new__(Rationals)
     elif (symengine.is_a_UniversalSet(deref(o))):
         r = Set.__new__(UniversalSet)
     elif (symengine.is_a_FiniteSet(deref(o))):
@@ -447,6 +449,8 @@ def sympy2symengine(a, raise_error=False):
         return S.Reals
     elif a is sympy.S.Integers:
         return S.Integers
+    elif a is sympy.S.Rationals:
+        return S.Rationals
     elif isinstance(a, sympy.Interval):
         return interval(*(a.args))
     elif a is sympy.S.EmptySet:
@@ -667,6 +671,10 @@ class Singleton(object):
     def Integers(self):
         return integers_singleton
 
+    @property
+    def Rationals(self):
+        return rationals_singleton
+
     @property
     def Reals(self):
         return reals_singleton
@@ -3010,6 +3018,20 @@ class Reals(Set):
         return self.__class__
 
 
+class Rationals(Set):
+
+    def __new__(self):
+        return rationals()
+
+    def _sympy_(self):
+        import sympy
+        return sympy.S.Rationals
+
+    @property
+    def func(self):
+        return self.__class__
+
+
 class Integers(Set):
 
     def __new__(self):
@@ -3614,6 +3636,14 @@ cdef class DenseMatrixBase(MatrixBase):
     def is_strongly_diagonally_dominant(self):
         return tribool(deref(symengine.static_cast_DenseMatrix(self.thisptr)).is_strictly_diagonally_dominant())
 
+    @property
+    def is_positive_definite(self):
+        return tribool(deref(symengine.static_cast_DenseMatrix(self.thisptr)).is_positive_definite())
+
+    @property
+    def is_negative_definite(self):
+        return tribool(deref(symengine.static_cast_DenseMatrix(self.thisptr)).is_negative_definite())
+
     @property
     def T(self):
         return self.transpose()
@@ -5177,6 +5207,10 @@ def reals():
     return c2py(<rcp_const_basic>(symengine.reals()))
 
 
+def rationals():
+    return c2py(<rcp_const_basic>(symengine.rationals()))
+
+
 def integers():
     return c2py(<rcp_const_basic>(symengine.integers()))
 
@@ -5291,6 +5325,7 @@ def imageset(sym, expr, base):
 
 universal_set_singleton = UniversalSet()
 integers_singleton = Integers()
+rationals_singleton = Rationals()
 reals_singleton = Reals()
 empty_set_singleton = EmptySet()
 

symengine/tests/test_matrices.py

@@ -385,6 +385,20 @@ def test_is_strongly_diagonally_dominant():
     assert C.is_strongly_diagonally_dominant is None
 
 
+def test_is_positive_definite():
+    A = DenseMatrix(2, 2, [2, 1, 1, 2])
+    assert A.is_positive_definite
+    C = DenseMatrix(3, 3, [Symbol('x'), 2, 0, 0, 4, 0, 0, 0, 4])
+    assert C.is_positive_definite is None
+
+
+def test_is_negative_definite():
+    A = DenseMatrix(2, 2, [-2, -1, -1, -2])
+    assert A.is_negative_definite
+    C = DenseMatrix(3, 3, [Symbol('x'), -2, 0, 0, -4, 0, 0, 0, -4])
+    assert C.is_negative_definite is None
+
+
 def test_LU():
     A = DenseMatrix(3, 3, [1, 3, 5, 2, 5, 6, 8, 3, 1])
     L, U = A.LU()

symengine/tests/test_sets.py

@@ -1,7 +1,7 @@
 from symengine.utilities import raises
 from symengine.lib.symengine_wrapper import (Interval, EmptySet, UniversalSet,
-    FiniteSet, Union, Complement, ImageSet, ConditionSet, Reals, Integers,
-    And, Or, oo, Symbol, true, Ge, Eq, Gt)
+    FiniteSet, Union, Complement, ImageSet, ConditionSet, Reals, Rationals,
+    Integers, And, Or, oo, Symbol, true, Ge, Eq, Gt)
 
 
 def test_Interval():
@@ -38,7 +38,13 @@ def test_Reals():
     assert R.contains(0) == true
 
 
-def test_Reals():
+def test_Rationals():
+    Q = Rationals()
+    assert Q.union(FiniteSet(2, 3)) == Q
+    assert Q.contains(0) == true
+
+
+def test_Integers():
     Z = Integers()
     assert Z.union(FiniteSet(2, 4)) == Z
     assert Z.contains(0) == true

symengine/tests/test_sympy_conv.py

@@ -9,7 +9,7 @@
         KroneckerDelta, LeviCivita, erf, erfc, lowergamma, uppergamma,
         loggamma, beta, polygamma, sign, floor, ceiling, conjugate, And,
         Or, Not, Xor, Piecewise, Interval, EmptySet, FiniteSet, Contains,
-        Union, Complement, UniversalSet, Reals, Integers)
+        Union, Complement, UniversalSet, Reals, Rationals, Integers)
 import unittest
 
 # Note: We test _sympy_() for SymEngine -> SymPy conversion, as those are
@@ -721,6 +721,9 @@ def test_sets():
     assert sympify(sympy.S.Reals) == Reals()
     assert sympy.S.Reals == Reals()._sympy_()
 
+    assert sympify(sympy.S.Rationals) == Rationals()
+    assert sympy.S.Rationals == Rationals()._sympy_()
+
     assert sympify(sympy.S.Integers) == Integers()
     assert sympy.S.Integers == Integers()._sympy_()
 

symengine_version.txt

@@ -1 +1 @@
-bb386f47369500d76cda07e6e9f014bfe6339f64
+bb386f47369500d76cda07e6e9f014bfe6339f64