raise an exception if conflicting shape is given to DenseMatrix at construction

Author: bjodah

symengine/lib/symengine_wrapper.pyx

@@ -3230,6 +3230,8 @@ cdef class DenseMatrixBase(MatrixBase):
                 raise ValueError("sizes don't match.")
             else:
                 self.thisptr = new symengine.DenseMatrix(0, 0, v_)
+        elif col is not None and (row*col != v_.size()):
+            raise ValueError("Number of elements should equal rows*columns.")
         else:
             self.thisptr = new symengine.DenseMatrix(row, v_.size() / row, v_)
 

symengine/tests/test_matrices.py

@@ -12,6 +12,10 @@
     HAVE_NUMPY = False
 
 
+def test_init():
+    raises(ValueError, DenseMatrix(2, 1, [0]*4))
+
+
 def test_get():
     A = DenseMatrix([[1, 2], [3, 4]])
 
@@ -230,7 +234,7 @@ def test_mul_matrix():
     assert A.mul_matrix(B) == DenseMatrix(2, 2, [a + b, 0, c + d, 0])
     assert A * B == DenseMatrix(2, 2, [a + b, 0, c + d, 0])
     assert A @ B == DenseMatrix(2, 2, [a + b, 0, c + d, 0])
-    assert (A @ DenseMatrix(2, 1, [0]*4)).shape == (2, 1)
+    assert (A @ DenseMatrix(2, 1, [0]*2)).shape == (2, 1)
 
     C = DenseMatrix(2, 3, [1, 2, 3, 2, 3, 4])
     D = DenseMatrix(3, 2, [3, 4, 4, 5, 5, 6])