Skip to content

Commit dc25c6a

Browse files
committed
Updated csv_previewer
1 parent 2379c20 commit dc25c6a

File tree

7 files changed

+21
-12
lines changed

7 files changed

+21
-12
lines changed

analysis_options.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@ include: package:flutter_lints/flutter.yaml
33
analyzer:
44
errors:
55
invalid_annotation_target: ignore
6+
exclude:
7+
- "**/*.freezed.dart"
8+
- "**/*.g.dart"
69

710
linter:
811
rules:

lib/consts.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ const Map<String, Map<String, List<ResponseBodyView>>>
378378
kSubTypeDefaultViewOptions: kRawBodyViewOptions,
379379
kSubTypeCss: kCodeRawBodyViewOptions,
380380
kSubTypeHtml: kCodeRawBodyViewOptions,
381-
kSubTypeCsv: kPreviewCodeRawBodyViewOptions,
381+
kSubTypeCsv: kPreviewRawBodyViewOptions,
382382
kSubTypeJavascript: kCodeRawBodyViewOptions,
383383
kSubTypeMarkdown: kCodeRawBodyViewOptions,
384384
kSubTypeTextXml: kCodeRawBodyViewOptions,
@@ -499,7 +499,6 @@ const kRaiseIssue =
499499
const kCsvError =
500500
"There seems to be an issue rendering this CSV. Please raise an issue in API Dash GitHub repo so that we can resolve it.";
501501

502-
503502
const kHintTextUrlCard = "Enter API endpoint like api.foss42.com/country/codes";
504503
const kLabelPlusNew = "+ New";
505504
const kLabelSend = "Send";

lib/widgets/csv_previewer.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import 'package:flutter/material.dart';
22
import 'package:csv/csv.dart';
3-
import 'package:apidash/consts.dart';
4-
import 'package:apidash/widgets/widgets.dart';
3+
import 'error_message.dart';
4+
import '../consts.dart';
55

66
class CsvPreviewer extends StatelessWidget {
7-
const CsvPreviewer({Key? key, required this.body}) : super(key: key);
7+
const CsvPreviewer({super.key, required this.body});
88

99
final String body;
1010

lib/widgets/json_previewer.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ class _JsonPreviewerState extends State<JsonPreviewer> {
154154

155155
@override
156156
void didUpdateWidget(JsonPreviewer oldWidget) {
157+
super.didUpdateWidget(oldWidget);
157158
if (oldWidget.code != widget.code) {
158159
store.buildNodes(widget.code, areAllCollapsed: true);
159160
store.expandAll();

lib/widgets/previewer.dart

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import 'dart:convert';
2-
import 'package:apidash/widgets/csv_previewer.dart';
32
import 'package:flutter/foundation.dart';
43
import 'package:flutter/material.dart';
54
import 'package:printing/printing.dart';
@@ -8,6 +7,7 @@ import 'package:vector_graphics_compiler/vector_graphics_compiler.dart';
87
import 'error_message.dart';
98
import 'uint8_audio_player.dart';
109
import 'json_previewer.dart';
10+
import 'csv_previewer.dart';
1111
import '../consts.dart';
1212

1313
class Previewer extends StatefulWidget {
@@ -83,11 +83,7 @@ class _PreviewerState extends State<Previewer> {
8383
);
8484
}
8585
if (widget.type == kTypeText && widget.subtype == kSubTypeCsv) {
86-
try {
87-
return CsvPreviewer(body: widget.body);
88-
} catch (e) {
89-
return const ErrorMessage(message: kCsvError);
90-
}
86+
return CsvPreviewer(body: widget.body);
9187
}
9288
if (widget.type == kTypeVideo) {
9389
// TODO: Video Player
@@ -97,5 +93,4 @@ class _PreviewerState extends State<Previewer> {
9793
: "$kMimeTypeRaiseIssueStart${widget.type}/${widget.subtype}$kMimeTypeRaiseIssue";
9894
return ErrorMessage(message: message);
9995
}
100-
10196
}

pubspec.lock

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,14 @@ packages:
217217
url: "https://pub.dev"
218218
source: hosted
219219
version: "3.0.3"
220+
csv:
221+
dependency: "direct main"
222+
description:
223+
name: csv
224+
sha256: "63ed2871dd6471193dffc52c0e6c76fb86269c00244d244297abbb355c84a86e"
225+
url: "https://pub.dev"
226+
source: hosted
227+
version: "5.1.1"
220228
dart_style:
221229
dependency: "direct main"
222230
description:

test/widget_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// ignore_for_file: unused_import
2+
// TODO: Added ignore to calculate code coverage
3+
14
import 'package:apidash/main.dart';
25
import 'package:apidash/app.dart';
36
import 'package:apidash/common/utils.dart';

0 commit comments

Comments
 (0)