Skip to content

Commit 885e8cb

Browse files
Keith HuiFelix Singer
Keith Hui
authored and
Felix Singer
committed
sb/intel/bd82x6x: Honor POST code Kconfig option
This southbridge can route POST codes written to port 0x80 to either LPC or PCI, but currently always route them to LPC. Change it so that POST codes are routed to PCI if CONFIG(POST_DEVICE_PCI_PCIE) is selected, LPC otherwise. Rename the static function because POST codes no longer always go to LPC. Change-Id: I455d7aff27154d6821e262a21248e8c7306e2d61 Signed-off-by: Keith Hui <[email protected]> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79725 Tested-by: build bot (Jenkins) <[email protected]> Reviewed-by: Felix Singer <[email protected]> Reviewed-by: Nico Huber <[email protected]>
1 parent 2562052 commit 885e8cb

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

src/southbridge/intel/bd82x6x/bootblock.c

+7-4
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,13 @@
55
#include <southbridge/intel/common/early_spi.h>
66
#include "pch.h"
77

8-
static void enable_port80_on_lpc(void)
8+
static void setup_port80(void)
99
{
10-
/* Enable port 80 POST on LPC */
11-
RCBA32(GCS) &= (~0x04);
10+
/* Enable port 80 POST */
11+
if (CONFIG(POST_DEVICE_PCI_PCIE))
12+
RCBA32(GCS) |= 0x04; /* ... on PCI(e) */
13+
else
14+
RCBA32(GCS) &= (~0x04); /* ... on LPC */
1215
}
1316

1417
static void set_spi_speed(void)
@@ -37,7 +40,7 @@ void bootblock_early_southbridge_init(void)
3740

3841
early_pch_init();
3942

40-
enable_port80_on_lpc();
43+
setup_port80();
4144
set_spi_speed();
4245

4346
/* Enable upper 128bytes of CMOS */

0 commit comments

Comments
 (0)