Skip to content

Commit 9e4b75c

Browse files
Raul E RangelMrChromebox
Raul E Rangel
authored andcommitted
toolchain: Print CC command and output when CC invocation fails
We are gobbling up the `$(CC_$(arch))` stderr when testing the toolchain. This change makes it so we print the command we tried to invoke and the output from the command. ``` toolchain.mk:183: The coreboot toolchain for 'x86_32' architecture was not found. toolchain.mk:183: /build/guybrush/tmp/portage/sys-boot/coreboot-9999/files/reclient/ccache /build/guybrush/tmp/portage/sys-boot/coreboot-9999/work/coreboot-sdk/bin/i386-elf-gcc -v I AM STDERR toolchain.mk:183: I AM STDOUT toolchain.mk:219: toolchain.mk:220: Path to your toolchain is currently set to '/build/guybrush/tmp/portage/sys-boot/coreboot-9999/work/coreboot-sdk/bin' toolchain.mk:222: toolchain.mk:223: To build the entire coreboot toolchain: run 'make crossgcc' ``` BUG=b:392874252, b:389737339 TEST=USE_REMOTEEXEC=true BOARD=brya bazel run @portage//internal/packages/stage2/target/board/chromiumos/sys-boot/coreboot:9999_debug Change-Id: I7c7352c7254c21deb3e4a03106b841ec9f111ba4 Signed-off-by: Raul E Rangel <[email protected]> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86220 Tested-by: build bot (Jenkins) <[email protected]> Reviewed-by: Jon Murphy <[email protected]>
1 parent 89ec6ab commit 9e4b75c

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

toolchain.mk

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,10 @@ $(foreach arch,$(sort $(foreach stage,\
187187
echo not-coreboot; else echo not-coreboot; fi), \
188188
$(eval COMPILERFAIL:=1)\
189189
$(warning The coreboot toolchain for '$(arch)'\
190-
architecture was not found.)))
190+
architecture was not found.)\
191+
$(if $(CC_$(arch)),\
192+
$(warning $(CC_$(arch)) -v)\
193+
$(warning $(shell $(CC_$(arch)) -v)))))
191194
# If iasl doesn't match the current coreboot version, fail the test
192195
# TODO: Figure out if iasl is even needed for the build.
193196
$(if $(shell if [ -n "$(IASL)" ]; then \

0 commit comments

Comments
 (0)