-
Notifications
You must be signed in to change notification settings - Fork 156
v4 classes are not sorted in monorepo where tailwindcss is not installed in package with .prettierrc
#340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Tailwindcss v4.0 was fully released yesterday. @adjsky Is there a quick and dirty fix that devs can use locally until this is patched? |
Yes, I've managed to make it work by creating a import config from '../../.prettierrc.json' with { type: 'json' };
export default {
...config,
tailwindStylesheet: './src/app.css',
}; I didn't check if I need Or you just could install |
@adjsky Want to collab? We should try to patch this for the hundreds of thousands of users that will be upgrading to v4 in the coming weeks and months. |
Not really sure it is related to this, but I am having issues with the sorting myself. I upgraded our project to v4 and the sorting went a bit out. You can check the branch of this PR: https://github.com/dfinity/oisy-wallet/pull/4665/files Ignore the rest and look at the Svelte files, the sorting is off. For example: the screens breakpoints ( |
Having the same issue as @AntonioVentilii - at least one breakpoint class is being sorted first. correct order with Tailwind 3
changed to this order under Tailwind 4
|
I think that this is tangentially related at most. I checked out the |
@8907234 the plugin is already working, but the sorting is wrong: it does not recognizes classes like Did you test and it was sorting the breakpoints correctly? |
What version of
prettier-plugin-tailwindcss
are you using?v0.6.9
What version of Tailwind CSS are you using?
v4.0.0-beta.9
What version of Node.js are you using?
v23.1.0
What package manager are you using?
pnpm v9.12.3
What operating system are you using?
macOS Version 15.1.1 (24B91)
Reproduction URL
https://github.com/adjsky/tailwind-prettier-monorepo-bug
rotate-360
is not sorted.pnpm add -w tailwindcss@4.0.0-beta.9
.rotate-360
is sorted.package.json
..prettierrc_
by removing underscore.rotate-360
is still sorted.Describe your issue
Plugin does not sort new classes (
rotate-360
,h-54.5
, ...) in a monorepo setup, wheretailwindcss
is installed in separate packages, but there is only one.prettierrc
in the monorepo root.As i see from the code, the plugin tries to import
tailwindcss
package from the base dir (where the prettier config is located):prettier-plugin-tailwindcss/src/config.ts
Line 200 in 9481dd0
but it fails (since there is no
tailwindcss
package in the root) and falls back to the v3 mode.This can be fixed by recursively resolving
tailwindcss
in each package from the input file path to thebaseDir
, or at least the current behavior could be documented.I can open PR with the fixes, if you are welcome.
The text was updated successfully, but these errors were encountered: