Skip to content

Commit 996f879

Browse files
authored
Merge pull request #177 from taks/fix-null-pointer-dereferences
Fix null pointer dereferences
2 parents 941f466 + 92061d7 commit 996f879

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/client/ble_client.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,9 +415,9 @@ impl BLEClient {
415415
}
416416

417417
let error = unsafe { &*error };
418-
let service = unsafe { &*service };
419418

420419
if error.status == 0 {
420+
let service = unsafe { &*service };
421421
// Found a service - add it to the vector
422422
let service = BLERemoteService::new(ArcUnsafeCell::downgrade(&client.state), service);
423423
client.state.services.as_mut().unwrap().push(service);

src/client/ble_remote_characteristic.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,9 +178,9 @@ impl BLERemoteCharacteristic {
178178
}
179179

180180
let error = unsafe { &*error };
181-
let dsc = unsafe { &*dsc };
182181

183182
if error.status == 0 {
183+
let dsc = unsafe { &*dsc };
184184
let descriptor =
185185
BLERemoteDescriptor::new(ArcUnsafeCell::downgrade(&characteristic.state), dsc);
186186
characteristic

src/client/ble_remote_service.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,9 @@ impl BLERemoteService {
9292
return 0;
9393
}
9494
let error = unsafe { &*error };
95-
let chr = unsafe { &*chr };
9695

9796
if error.status == 0 {
97+
let chr = unsafe { &*chr };
9898
let chr = BLERemoteCharacteristic::new(ArcUnsafeCell::downgrade(&service.state), chr);
9999
service.state.characteristics.as_mut().unwrap().push(chr);
100100
return 0;

0 commit comments

Comments
 (0)