Skip to content

Commit fd7988d

Browse files
committed
Run CI jobs on Node 23.x
23.x is now the current Node version. We should run the CI on that version so it doesn't diverge too much from what is likely to be our local setup. Intl.DurationFormat is available in that release so we can remove one test from the ignore file.
1 parent a8b5a53 commit fd7988d

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

.github/workflows/test.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ jobs:
99
runs-on: ubuntu-latest
1010
steps:
1111
- uses: actions/checkout@v3
12-
- name: use node.js v20.x
12+
- name: use node.js v23.x
1313
uses: actions/setup-node@v3
1414
with:
15-
node-version: 20.x
15+
node-version: 23.x
1616
- run: npm ci
1717
- run: npm run test-demitasse
1818
env:
@@ -23,10 +23,10 @@ jobs:
2323
- uses: actions/checkout@v3
2424
with:
2525
submodules: true
26-
- name: use node.js v20.x
26+
- name: use node.js v23.x
2727
uses: actions/setup-node@v3
2828
with:
29-
node-version: 20.x
29+
node-version: 23.x
3030
- run: npm run codecov:test262
3131
- uses: codecov/codecov-action@v4
3232
with:
@@ -38,20 +38,20 @@ jobs:
3838
runs-on: ubuntu-latest
3939
steps:
4040
- uses: actions/checkout@v3
41-
- name: use node.js v20.x
41+
- name: use node.js v23.x
4242
uses: actions/setup-node@v3
4343
with:
44-
node-version: 20.x
44+
node-version: 23.x
4545
- run: npm ci
4646
- run: npm run test-cookbook
4747
test-validstrings:
4848
runs-on: ubuntu-latest
4949
steps:
5050
- uses: actions/checkout@v3
51-
- name: use node.js v20.x
51+
- name: use node.js v23.x
5252
uses: actions/setup-node@v3
5353
with:
54-
node-version: 20.x
54+
node-version: 23.x
5555
- run: npm ci
5656
- run: |
5757
cd polyfill

polyfill/test/expected-failures.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,3 @@ staging/sm/Temporal/PlainDate/from-islamic-umalqura.js
2727
# Faulty leap month calculations in Chinese calendar in ICU4C
2828
# https://unicode-org.atlassian.net/browse/ICU-22230
2929
staging/sm/Temporal/PlainMonthDay/from-chinese-leap-month-uncommon.js
30-
31-
# Fails until Intl.DurationFormat available in Node.js release
32-
intl402/Temporal/Duration/prototype/toLocaleString/returns-same-results-as-DurationFormat.js

0 commit comments

Comments
 (0)