Skip to content

[MenuField] Re-opening menu while transition closed causes classes to be undefined (instead of default) #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
techniq opened this issue Sep 21, 2023 · 1 comment

Comments

@techniq
Copy link
Owner

techniq commented Sep 21, 2023

If you quickly click to re-open the menu while it's transitioning closed,classes within MenuItem will be set to undefined instead of default object/styles.

CleanShot.2023-09-21.at.10.04.56.2.mp4

Within MenuField, If you don't pass classes to MenuItem or set it explicitly to undefined (<MenuItem classes={undefined} />), the issue does not present.

@techniq techniq changed the title [MenuField] Re-opening menu while transition close causes classes to be undefined (instead of default) [MenuField] Re-opening menu while transition closed causes classes to be undefined (instead of default) Sep 21, 2023
@techniq
Copy link
Owner Author

techniq commented Dec 20, 2023

This also occurs if you click on the chevron toggle button to close a menu already opened. See #155 (comment) for some context.

Would be good to test with Svelte 5 to see if this is still an issue. For the chevon button issue, ultimately it would be nice if the menu was closed and not quickly re-opened. See issue #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant