SCAL-252103: Implement event for SAML popup closed without authentication (#201)

Co-authored-by: saikumar.anupuram <[email protected]>

Author: saikumar-anapuram

src/auth.spec.ts

@@ -385,6 +385,45 @@ describe('Unit test for auth', () => {
             expect(global.window.location.href).toBe(samalLoginUrl);
         });
 
+        it('should emit SAML_POPUP_CLOSED_NO_AUTH when popup window is closed', async () => {
+            jest.useFakeTimers();
+            const mockPopupWindow = { 
+                closed: false, 
+                focus: jest.fn(),
+                close: jest.fn()
+            };
+            global.window.open = jest.fn().mockReturnValue(mockPopupWindow);
+            Object.defineProperty(window, 'location', {
+                value: {
+                    href: '',
+                    hash: '',
+                },
+            });
+            spyOn(authInstance, 'samlCompletionPromise').and.returnValue(Promise.resolve(false));
+             const emitSpy = jest.fn();
+            const mockEventEmitter = { 
+                emit: emitSpy,
+                once: jest.fn(),
+                on: jest.fn()
+            };
+            authInstance.setAuthEE(mockEventEmitter as any);
+            jest.spyOn(tokenAuthService, 'isActiveService')
+                .mockReturnValueOnce(false)
+                .mockReturnValueOnce(true);
+            expect(
+                await authInstance.doSamlAuth({
+                    ...embedConfig.doSamlAuthNoRedirect,
+                }),
+            ).toBe(true);
+            document.getElementById('ts-auth-btn').click();
+            mockPopupWindow.closed = true;
+            jest.advanceTimersByTime(1000);
+            window.postMessage({ type: EmbedEvent.SAMLComplete }, '*');
+            await authInstance.samlCompletionPromise;
+            expect(emitSpy).toHaveBeenCalledWith(authInstance.AuthStatus.SAML_POPUP_CLOSED_NO_AUTH);
+            jest.useRealTimers();
+            authInstance.setAuthEE(null);
+        });
         it('when user is not loggedIn, in config noRedirect is true and isAtSSORedirectUrl is false', async () => {
             Object.defineProperty(window, 'location', {
                 value: {
@@ -408,6 +447,19 @@ describe('Unit test for auth', () => {
             await authInstance.samlCompletionPromise;
             expect(authInstance.loggedInStatus).toBe(true);
         });
+
+        it('should support emitting SAML_POPUP_CLOSED_NO_AUTH event', () => {
+            const emitSpy = jest.fn();
+            const mockEventEmitter = { 
+                emit: emitSpy,
+                once: jest.fn()
+            };
+            authInstance.setAuthEE(mockEventEmitter as any);
+            authInstance.getAuthEE().emit(authInstance.AuthStatus.SAML_POPUP_CLOSED_NO_AUTH);
+            expect(emitSpy).toHaveBeenCalledWith(authInstance.AuthStatus.SAML_POPUP_CLOSED_NO_AUTH);
+            authInstance.setAuthEE(null);
+        });
+
     });
 
     describe('doOIDCAuth', () => {

src/auth.ts

@@ -77,6 +77,11 @@ export enum AuthStatus {
      * @version SDK: 1.19.0
      */
     WAITING_FOR_POPUP = 'WAITING_FOR_POPUP',
+
+    /**
+     * Emitted when the SAML popup is closed without authentication
+     */
+    SAML_POPUP_CLOSED_NO_AUTH = 'SAML_POPUP_CLOSED_NO_AUTH',
 }
 
 /**
@@ -96,13 +101,13 @@ export interface AuthEventEmitter {
      * @param listener
      */
     on(
-        event: AuthStatus.SDK_SUCCESS | AuthStatus.LOGOUT | AuthStatus.WAITING_FOR_POPUP,
+        event: AuthStatus.SDK_SUCCESS | AuthStatus.LOGOUT | AuthStatus.WAITING_FOR_POPUP | AuthStatus.SAML_POPUP_CLOSED_NO_AUTH,
         listener: () => void,
     ): this;
     on(event: AuthStatus.SUCCESS, listener: (sessionInfo: any) => void): this;
     once(event: AuthStatus.FAILURE, listener: (failureType: AuthFailureType) => void): this;
     once(
-        event: AuthStatus.SDK_SUCCESS | AuthStatus.LOGOUT | AuthStatus.WAITING_FOR_POPUP,
+        event: AuthStatus.SDK_SUCCESS | AuthStatus.LOGOUT | AuthStatus.WAITING_FOR_POPUP | AuthStatus.SAML_POPUP_CLOSED_NO_AUTH,
         listener: () => void,
     ): this;
     once(event: AuthStatus.SUCCESS, listener: (sessionInfo: any) => void): this;
@@ -364,17 +369,29 @@ export const doBasicAuth = async (embedConfig: EmbedConfig): Promise<boolean> =>
  * @param triggerText
  */
 async function samlPopupFlow(ssoURL: string, triggerContainer: DOMSelector, triggerText: string) {
+    let popupClosedCheck: NodeJS.Timeout;
     const openPopup = () => {
         if (samlAuthWindow === null || samlAuthWindow.closed) {
             samlAuthWindow = window.open(
                 ssoURL,
                 '_blank',
                 'location=no,height=570,width=520,scrollbars=yes,status=yes',
             );
+            if (samlAuthWindow) {
+                popupClosedCheck = setInterval(() => {
+                    if (samlAuthWindow.closed) {
+                        clearInterval(popupClosedCheck);
+                        if (samlCompletionPromise && !samlCompletionResolved) {
+                            authEE?.emit(AuthStatus.SAML_POPUP_CLOSED_NO_AUTH);
+                        }
+                    }
+                }, 500);
+            }
         } else {
             samlAuthWindow.focus();
         }
     };
+    let samlCompletionResolved = false;
     authEE?.emit(AuthStatus.WAITING_FOR_POPUP);
     const containerEl = getDOMNode(triggerContainer);
     if (containerEl) {
@@ -386,6 +403,10 @@ async function samlPopupFlow(ssoURL: string, triggerContainer: DOMSelector, trig
     samlCompletionPromise = samlCompletionPromise || new Promise<void>((resolve, reject) => {
         window.addEventListener('message', (e) => {
             if (e.data.type === EmbedEvent.SAMLComplete) {
+                samlCompletionResolved = true;
+                if (popupClosedCheck) {
+                    clearInterval(popupClosedCheck);
+                }
                 (e.source as Window).close();
                 resolve();
             }