Skip to content

Commit f9c2aab

Browse files
committed
Clean up for release
1 parent 742a266 commit f9c2aab

File tree

4 files changed

+12
-11
lines changed

4 files changed

+12
-11
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Package: haven
22
Title: Import and Export 'SPSS', 'Stata' and 'SAS' Files
33
Version: 2.5.1.9000
44
Authors@R: c(
5-
person("Hadley", "Wickham", , "hadley@rstudio.com", role = c("aut", "cre")),
5+
person("Hadley", "Wickham", , "hadley@posit.co", role = c("aut", "cre")),
66
person("Evan", "Miller", role = c("aut", "cph"),
77
comment = "Author of included ReadStat code"),
88
person("Danny", "Smith", role = "aut"),

NEWS.md

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,12 @@
77
* Ignore invalid SAV timestamp strings (#683).
88
* Fix compiler warnings (#707).
99

10+
* The experimental `write_sas()` function has been deprecated (#224). The
11+
sas7bdat file format is complex and undocumented, and as such writing SAS
12+
files is not officially supported by ReadStat. `write_xpt()` should be used
13+
instead - it produces files in the SAS transport format, which has
14+
limitations but will be reliably read by SAS.
15+
1016
* `write_*()` functions gain a new `adjust_tz` argument to allow more control
1117
over time zone conversion for date-time variables (#702). Thanks to @jmobrien
1218
for the detailed issue and feedback.
@@ -22,14 +28,9 @@
2228
the corresponding UTC value, which will appear different to the user but
2329
preserves the underlying numeric data.
2430

25-
* Fixed issue in `write_*()` functions where invisible return of input data
26-
frame included unintended alteration of date time variables. (@jmobrien, #702)
27-
28-
* The experimental `write_sas()` function has been deprecated (#224). The
29-
sas7bdat file format is complex and undocumented, and as such writing SAS
30-
files is not officially supported by ReadStat. `write_xpt()` should be used
31-
instead - it produces files in the SAS transport format, which has
32-
limitations but will be reliably read by SAS.
31+
* `write_*()` functions previously returned the data frame with minor
32+
alterations made to date-time variables. These functions now invisibly return
33+
the original input data frame unchanged (@jmobrien, #702).
3334

3435
* Fix bug in string variable width calculation that treated `NA` values as width
3536
2. `NA` values are now treated as blanks for width calculations (#699).

R/haven-sas.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ read_sas <- function(data_file, catalog_file = NULL,
8080
#' @keywords internal
8181
#' @export
8282
write_sas <- function(data, path) {
83-
lifecycle::deprecate_warn("2.6.0", "write_sas()", "write_xpt()")
83+
lifecycle::deprecate_warn("2.5.2", "write_sas()", "write_xpt()")
8484

8585
validate_sas(data)
8686
data_out <- adjust_tz(data)

vignettes/datetimes.Rmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ DateTime (number of seconds):
3535
Dates and date times use a difference offset to R:
3636

3737
* SAS: 1960-01-01 (`r -as.integer(as.Date("1960-01-01"))` days)
38-
* Spss: 1582-10-14. (`r -as.integer(as.Date("1582-10-14"))` days)
38+
* SPSS: 1582-10-14. (`r -as.integer(as.Date("1582-10-14"))` days)
3939
* Stata: 1960-01-01. (`r -as.integer(as.Date("1960-01-01"))` days)
4040

4141

0 commit comments

Comments
 (0)