Skip to content

Commit 4518362

Browse files
committed
mgr/dashboard: update node js version
Fixes: https://tracker.ceph.com/issues/66249 Signed-off-by: Ivo Almeida <[email protected]>
1 parent 3a9fd84 commit 4518362

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

doc/dev/developer_guide/dash-devel.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,8 +214,8 @@ The build process is based on `Node.js <https://nodejs.org/>`_ and requires the
214214
Prerequisites
215215
~~~~~~~~~~~~~
216216

217-
* Node 18.17.0 or higher
218-
* NPM 9.6.7 or higher
217+
* Node 20.13.1 or higher
218+
* NPM 10.5.2 or higher
219219

220220
nodeenv:
221221
During Ceph's build we create a virtualenv with ``node`` and ``npm``

make-dist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ build_dashboard_frontend() {
132132

133133
$CURR_DIR/src/tools/setup-virtualenv.sh $TEMP_DIR
134134
$TEMP_DIR/bin/pip install nodeenv
135-
$TEMP_DIR/bin/nodeenv --verbose -p --node=18.17.0
135+
$TEMP_DIR/bin/nodeenv --verbose -p --node=20.13.1
136136
cd src/pybind/mgr/dashboard/frontend
137137

138138
. $TEMP_DIR/bin/activate

src/pybind/mgr/dashboard/frontend/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ else(WITH_SYSTEM_NPM)
6464
OUTPUT "${mgr-dashboard-nodeenv-dir}/bin/npm"
6565
COMMAND ${CMAKE_SOURCE_DIR}/src/tools/setup-virtualenv.sh --python=${MGR_PYTHON_EXECUTABLE} ${mgr-dashboard-nodeenv-dir}
6666
COMMAND ${mgr-dashboard-nodeenv-dir}/bin/pip install nodeenv
67-
COMMAND ${mgr-dashboard-nodeenv-dir}/bin/nodeenv --verbose ${node_mirror_opt} -p --node=18.17.0
67+
COMMAND ${mgr-dashboard-nodeenv-dir}/bin/nodeenv --verbose ${node_mirror_opt} -p --node=20.13.1
6868
COMMAND mkdir ${mgr-dashboard-nodeenv-dir}/.npm
6969
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
7070
COMMENT "dashboard nodeenv is being installed")

0 commit comments

Comments
 (0)